8261106: Reduce inclusion of jniHandles.hpp

[iklam]

niHandles.hpp is included by about 800 out of 1000 HotSpot .o files. Most of these are transitively included from these header files, which don't actually need to include jniHandles.hpp.

• ci/ciBaseObject.hpp
• ci/ciMetadata.hpp
• ci/ciObject.hpp
• classfile/moduleEntry.hpp
• gc/shared/gcVMOperations.hpp
• jvmci/jvmciJavaClasses.hpp
• runtime/thread.hpp
• services/threadService.hpp

Fixing these headers reduces the number of .o files that include jniHandles.hpp to 145.

Note: 43 files were changed in this PR. Most of them were using jniHandles.hpp but were not including it directly.

Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261106: Reduce inclusion of jniHandles.hpp

Reviewers

• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to e7f2d09
• Harold Seigel (@hseigel - Reviewer) ⚠️ Review applies to e7f2d09

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2393/head:pull/2393
$ git checkout pull/2393

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following labels will be automatically applied to this pull request:

• hotspot
• serviceability
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[iklam]

/label remove serviceability

[openjdk]

@iklam
The serviceability label was successfully removed.

[mlbridge]

Webrevs

• 01: Full - Incremental (6e77fbe)
• 00: Full (e7f2d09)

[coleenp]

Ok! Seems trivial since I assume you've built this everywhere.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261106: Reduce inclusion of jniHandles.hpp

Reviewed-by: coleenp, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• e93e1e1: 8261157: Incorrect GPL header after JDK-8259956

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hseigel]

LGTM!
Harold

[iklam]

Thanks @coleenp and @hseigel for the review.
/integrate

[openjdk]

@iklam Since your change was applied there have been 3 commits pushed to the master branch:

• d9aefa3: 8260356: (tz) Upgrade time-zone data to tzdata2021a
• bdcbfa1: 8259927: Windows jpackage installer issues
• e93e1e1: 8261157: Incorrect GPL header after JDK-8259956

Your commit was automatically rebased without conflicts.

Pushed as commit c59e4b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.