-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346825: [JVMCI] Remove NativeImageReinitialize annotation #23957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
|
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review. /integrate |
|
Going to push as commit 99547c5.
Your commit was automatically rebased without conflicts. |
The
jdk.vm.ci.common.NativeImageReinitializeannotation was introduced to reset JVMCI and Graal fields to their default values as they are copied into the libgraal image. Now that class loader separation is used to isolate the JVMCI and Graal classes compiled to produce libgraal from the JVMCI and Graal classes being executed to do the AOT compilation, the need for this field resetting is no longer needed. This PR removes theNativeImageReinitializeannotation.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23957/head:pull/23957$ git checkout pull/23957Update a local copy of the PR:
$ git checkout pull/23957$ git pull https://git.openjdk.org/jdk.git pull/23957/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23957View PR using the GUI difftool:
$ git pr show -t 23957Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23957.diff
Using Webrev
Link to Webrev Comment