Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Mar 9, 2025

The jdk.vm.ci.common.NativeImageReinitialize annotation was introduced to reset JVMCI and Graal fields to their default values as they are copied into the libgraal image. Now that class loader separation is used to isolate the JVMCI and Graal classes compiled to produce libgraal from the JVMCI and Graal classes being executed to do the AOT compilation, the need for this field resetting is no longer needed. This PR removes the NativeImageReinitialize annotation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346825: [JVMCI] Remove NativeImageReinitialize annotation (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23957/head:pull/23957
$ git checkout pull/23957

Update a local copy of the PR:
$ git checkout pull/23957
$ git pull https://git.openjdk.org/jdk.git pull/23957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23957

View PR using the GUI difftool:
$ git pr show -t 23957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23957.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2025

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 9, 2025

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346825: [JVMCI] Remove NativeImageReinitialize annotation

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ec683a1: 8351419: java.net.http: Cleanup links in HttpResponse and module-info API doc comments
  • f61f520: 8350325: [PPC64] ConvF2HFIdealizationTests timeouts on Power8
  • 783eda9: 8350266: [PPC64] Interpreter: intrinsify Thread.currentThread()
  • 19b9f11: 8351392: C2 crash: failed: Expected Bool, but got OpaqueMultiversioning
  • 18931d0: 8351399: AIX: clang pollutes the burned-in library search paths of the generated executables / Second try with a better solution than JDK8348663
  • 0887262: 8344301: Refine stylesheet for API docs
  • 84f71dd: 8349849: PKCS11 SunTlsKeyMaterial crashes when used with TLS1.2 TlsKeyMaterialParameterSpec

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 9, 2025
@openjdk
Copy link

openjdk bot commented Mar 9, 2025

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Mar 9, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 9, 2025

Webrevs

@dougxc dougxc changed the title 8346825: [JVMCI] Remove NativeImageReinitialize annotationremoved NativeImageReinitialize annotation 8346825: [JVMCI] Remove NativeImageReinitialize annotation Mar 10, 2025
@dougxc
Copy link
Member Author

dougxc commented Mar 10, 2025

Thanks for the review.

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 99547c5.
Since your change was applied there have been 7 commits pushed to the master branch:

  • ec683a1: 8351419: java.net.http: Cleanup links in HttpResponse and module-info API doc comments
  • f61f520: 8350325: [PPC64] ConvF2HFIdealizationTests timeouts on Power8
  • 783eda9: 8350266: [PPC64] Interpreter: intrinsify Thread.currentThread()
  • 19b9f11: 8351392: C2 crash: failed: Expected Bool, but got OpaqueMultiversioning
  • 18931d0: 8351399: AIX: clang pollutes the burned-in library search paths of the generated executables / Second try with a better solution than JDK8348663
  • 0887262: 8344301: Refine stylesheet for API docs
  • 84f71dd: 8349849: PKCS11 SunTlsKeyMaterial crashes when used with TLS1.2 TlsKeyMaterialParameterSpec

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@dougxc Pushed as commit 99547c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants