8351266: JFR: -XX:StartFlightRecording:report-on-exit

[egahlin]

Could I have a review of an enhancement that prints 'jfr view' when the JVM exits? The purpose is to simplify usage and avoid the need to dump to a file.

For more details, see the CSR

Example usage:

$ java -XX:StartFlightRecording:report-on-exit=hot-methods ...
[0.166s][info][jfr,startup] Started recording 1. No limit specified, using maxsize=250MB as default.
[0.166s][info][jfr,startup] 
[0.166s][info][jfr,startup] Use jcmd 66977 JFR.dump name=1 filename=FILEPATH to copy recording data to file.

                                          Java Methods that Executes the Most

Method                                                                                                  Samples Percent
------------------------------------------------------------------------------------------------------- ------- -------
sun.java2d.marlin.Renderer._endRendering(int, int)                                                          120  33.99%
sun.java2d.marlin.MarlinTileGenerator.getAlphaRLE(byte[], int, int)                                          22   6.23%
sun.awt.image.PNGImageDecoder.produceImage()                                                                 19   5.38%
sun.java2d.marlin.MarlinCache.copyAARowRLE_WithBlockFlags(int[], int[], int, int, int)                       14   3.97%
sun.java2d.marlin.MarlinTileGenerator.getAlphaNoRLE(byte[], int, int)                                         7   1.98%
sun.java2d.marlin.Renderer.copyAARow(int[], int, int, int, boolean)                                           7   1.98%
sun.awt.image.PNGImageDecoder.filterRow(byte[], byte[], int, int, int)                                        7   1.98%
sun.java2d.marlin.MarlinCache.copyAARowNoRLE(int[], int, int, int)                                            5   1.42%
sun.java2d.pipe.BufferedContext.validate(...)                                                                 5   1.42%
java.awt.GradientPaintContext.clipFillRaster(int[], int, int, int, int, double, double, double)               3   0.85%

Testing: jdk/jdk/jfr

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8351370 to be approved

Issues

• JDK-8351266: JFR: -XX:StartFlightRecording:report-on-exit (Enhancement - P3)
• JDK-8351370: JFR: -XX:StartFlightRecording:report-on-exit (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23958/head:pull/23958
$ git checkout pull/23958

Update a local copy of the PR:
$ git checkout pull/23958
$ git pull https://git.openjdk.org/jdk.git pull/23958/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23958

View PR using the GUI difftool:
$ git pr show -t 23958

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23958.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351266: JFR: -XX:StartFlightRecording:report-on-exit

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 109 new commits pushed to the master branch:

• 03ef79c: 8346470: Improve WriteBarrier JMH to have old-to-young refs
• b50fe9b: 8280818: Expand bug8033699.java to iterate over all LaFs
• 771e160: 8351323: Parameterize compiler and linker flags for iconv
• 0ff1c08: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll
• 37ec796: 8351500: G1: NUMA migrations cause crashes in region allocation
• 4e51a8c: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)
• 7e3bc81: 8351216: ZGC: Store NUMA node count
• 82eb780: 8351349: GSSUtil.createSubject has outdated access control context and policy related text
• c3db667: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings
• 375722f: 8351839: RISC-V: Fix base offset calculation introduced in JDK-8347489
• ... and 99 more: https://git.openjdk.org/jdk/compare/caaf4098452476d981183ad4302b76b9c883a72b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (4cf2ecde)
• 02: Full - Incremental (c0a2ae4a)
• 01: Full - Incremental (2f0d5a0b)
• 00: Full (6d6723e0)

[mgronlun]

Very convenient feature, Erik! Well done.

[egahlin]

/integrate

[openjdk]

@egahlin This pull request has not yet been marked as ready for integration.

[mgronlun]

Still good.

[egahlin]

/integrate

[openjdk]

Going to push as commit 248c373.
Since your change was applied there have been 109 commits pushed to the master branch:

• 03ef79c: 8346470: Improve WriteBarrier JMH to have old-to-young refs
• b50fe9b: 8280818: Expand bug8033699.java to iterate over all LaFs
• 771e160: 8351323: Parameterize compiler and linker flags for iconv
• 0ff1c08: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll
• 37ec796: 8351500: G1: NUMA migrations cause crashes in region allocation
• 4e51a8c: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)
• 7e3bc81: 8351216: ZGC: Store NUMA node count
• 82eb780: 8351349: GSSUtil.createSubject has outdated access control context and policy related text
• c3db667: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings
• 375722f: 8351839: RISC-V: Fix base offset calculation introduced in JDK-8347489
• ... and 99 more: https://git.openjdk.org/jdk/compare/caaf4098452476d981183ad4302b76b9c883a72b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 248c373.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.