Skip to content

Conversation

@hns
Copy link
Member

@hns hns commented Mar 10, 2025

Please review a change to fix the HTML for the new Keyboard Navigation section added in JDK-8350638. Instead of adding the <ul> element to the <p> element, both elements are added to the <section> element.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351555: Help section added in JDK-8350638 uses invalid HTML (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23969/head:pull/23969
$ git checkout pull/23969

Update a local copy of the PR:
$ git checkout pull/23969
$ git pull https://git.openjdk.org/jdk.git pull/23969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23969

View PR using the GUI difftool:
$ git pr show -t 23969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23969.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351555: Help section added in JDK-8350638 uses invalid HTML

Reviewed-by: liach, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 8450ae9: 8351440: Link with -reproducible on macOS
  • b40be22: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges
  • 6b84bde: 8350007: Add usage message to the javadoc executable
  • 32f2c2d: 8351017: ChronoUnit.MONTHS.between() not giving correct result when date is in February

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Mar 10, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2025
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as noreg-trivial, I would suggest noreg-other, since the output is not dependent on user input and should be caught by tidy`

@hns
Copy link
Member Author

hns commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 7999091.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 8450ae9: 8351440: Link with -reproducible on macOS
  • b40be22: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges
  • 6b84bde: 8350007: Add usage message to the javadoc executable
  • 32f2c2d: 8351017: ChronoUnit.MONTHS.between() not giving correct result when date is in February

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@hns Pushed as commit 7999091.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants