Skip to content

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Mar 10, 2025

Remove misleading/invalid diagnostic output from the JAR manifest test ValueUtf8Coding.java.

The Manifest binary stream is not a well formed UTF-8 string due to the inserted continuation characters used for lines longer than 70 characters..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23971/head:pull/23971
$ git checkout pull/23971

Update a local copy of the PR:
$ git checkout pull/23971
$ git pull https://git.openjdk.org/jdk.git pull/23971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23971

View PR using the GUI difftool:
$ git pr show -t 23971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23971.diff

Using Webrev

Link to Webrev Comment

…stic output

Remove misleading/invalid diagnostic output.
The Manifest binary stream is not a well formed UTF-8 string due to
the inserted continuation characters used for lines longer than 70 characters..
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2025

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output

Reviewed-by: lancea, bpb, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 73465b9: 8160327: Support for thumbnails present in APP1 marker for JPEG

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 10, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2025
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit ffa6340.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8d8bd0c: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
  • 73465b9: 8160327: Support for thumbnails present in APP1 marker for JPEG

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@RogerRiggs Pushed as commit ffa6340.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants