-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output #23971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…stic output Remove misleading/invalid diagnostic output. The Manifest binary stream is not a well formed UTF-8 string due to the inserted continuation characters used for lines longer than 70 characters..
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/integrate |
|
Going to push as commit ffa6340.
Your commit was automatically rebased without conflicts. |
|
@RogerRiggs Pushed as commit ffa6340. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Remove misleading/invalid diagnostic output from the JAR manifest test ValueUtf8Coding.java.
The Manifest binary stream is not a well formed UTF-8 string due to the inserted continuation characters used for lines longer than 70 characters..
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23971/head:pull/23971$ git checkout pull/23971Update a local copy of the PR:
$ git checkout pull/23971$ git pull https://git.openjdk.org/jdk.git pull/23971/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23971View PR using the GUI difftool:
$ git pr show -t 23971Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23971.diff
Using Webrev
Link to Webrev Comment