Skip to content

8351995: JFR: Leftovers from removal of Security Manager#24044

Closed
egahlin wants to merge 2 commits intoopenjdk:masterfrom
egahlin:remove-sm-fallout
Closed

8351995: JFR: Leftovers from removal of Security Manager#24044
egahlin wants to merge 2 commits intoopenjdk:masterfrom
egahlin:remove-sm-fallout

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Mar 14, 2025

Could I have a review of a PR that removes leftovers from the removal of the Security Manager.

Testing: jdk/jdk/jfr + tier1

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351995: JFR: Leftovers from removal of Security Manager (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24044/head:pull/24044
$ git checkout pull/24044

Update a local copy of the PR:
$ git checkout pull/24044
$ git pull https://git.openjdk.org/jdk.git pull/24044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24044

View PR using the GUI difftool:
$ git pr show -t 24044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24044.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351995: JFR: Leftovers from removal of Security Manager

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • e62becc: 8350964: Add an ArtifactResolver.fetch(clazz) method
  • dbf47d6: 8351876: RISC-V: enable and fix some float round tests
  • d207ed3: 8352066: JVM.commit() and JVM.flush() exhibit race conditions against JFR epochs
  • 0450ba9: 8351999: JFR: Incorrect scaling of throttled values
  • e5666f5: 8351976: assert(vthread_epoch == current_epoch) failed: invariant
  • 2eecf15: 8351967: JFR: AnnotationIterator should handle num_annotations = 0
  • c8913d2: 8345555: Improve layout of search results
  • e29d405: 8352110: [BACKOUT] C2: Print compilation bailouts with PrintCompilation compile command
  • 9f8d833: 8346194: Improve G1 pre-barrier C2 cost estimate
  • 2672c40: 8351167: ZGC: Lazily initialize livemap
  • ... and 10 more: https://git.openjdk.org/jdk/compare/0454406417701341dafa0d733cd480c145673d32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Mar 14, 2025
@egahlin egahlin marked this pull request as ready for review March 14, 2025 16:18
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 17, 2025
@egahlin
Copy link
Member Author

egahlin commented Mar 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

Going to push as commit d68775d.
Since your change was applied there have been 20 commits pushed to the master branch:

  • e62becc: 8350964: Add an ArtifactResolver.fetch(clazz) method
  • dbf47d6: 8351876: RISC-V: enable and fix some float round tests
  • d207ed3: 8352066: JVM.commit() and JVM.flush() exhibit race conditions against JFR epochs
  • 0450ba9: 8351999: JFR: Incorrect scaling of throttled values
  • e5666f5: 8351976: assert(vthread_epoch == current_epoch) failed: invariant
  • 2eecf15: 8351967: JFR: AnnotationIterator should handle num_annotations = 0
  • c8913d2: 8345555: Improve layout of search results
  • e29d405: 8352110: [BACKOUT] C2: Print compilation bailouts with PrintCompilation compile command
  • 9f8d833: 8346194: Improve G1 pre-barrier C2 cost estimate
  • 2672c40: 8351167: ZGC: Lazily initialize livemap
  • ... and 10 more: https://git.openjdk.org/jdk/compare/0454406417701341dafa0d733cd480c145673d32...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2025
@openjdk openjdk bot closed this Mar 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@egahlin Pushed as commit d68775d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants