Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset #2405

Closed
wants to merge 9 commits into from

Conversation

@fguallini
Copy link
Contributor

@fguallini fguallini commented Feb 4, 2021

The server side is binding to the wildcard address which has been a source of instability in many networking tests due to javax.net.ssl.SSLException: Connection reset. Changing the following tests to bind to loopback address fixes intermittent failures:
sun/security/ssl/SSLSocketImpl/ReverseNameLookup.java
javax/net/ssl/TLSCommon/TLSTest.java
sun/security/ssl/CipherSuite/SupportedGroups.java

javax/net/ssl/SSLSession/TestEnabledProtocols.java still throws a connection reset occasionally because the server closes the connection before the client is done during handshake. That race condition cannot be completely removed in this test, thus is now handled and logged.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2405/head:pull/2405
$ git checkout pull/2405

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2021

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2021

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Feb 4, 2021
@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Feb 4, 2021

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2021

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

⚠️ @fguallini This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

dfuch
dfuch approved these changes Feb 5, 2021
Copy link
Member

@dfuch dfuch left a comment

The new changes look goo to me. Please wait to get approval from someone from security-dev before pushing.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset

Reviewed-by: dfuchs, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 200 new commits pushed to the master branch:

  • 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
  • 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
  • 8ba390d: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • 16bd7d3: 8261336: IGV: enhance default filters
  • 3f8819c: 8261501: Shenandoah: reconsider heap statistics memory ordering
  • 3cbd16d: 8259668: Make SubTasksDone use-once
  • 219b115: 8261422: Adjust problematic String.format calls in jdk/internal/util/Preconditions.java outOfBoundsMessage
  • cdc874d: 8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0
  • e2d52ae: 8261413: Shenandoah: Disable class-unloading in I-U mode
  • 34ae7ae: 8261609: remove remnants of XML-driven builders
  • ... and 190 more: https://git.openjdk.java.net/jdk/compare/a421bfad285584430c8bd2f035ccc35b62598b17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 5, 2021
dfuch
dfuch approved these changes Feb 11, 2021
Copy link
Member

@dfuch dfuch left a comment

LGTM

@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Feb 16, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@fguallini
Your change (at version aa0e146) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

@rhalade rhalade commented Feb 16, 2021

/sponsor

@openjdk openjdk bot closed this Feb 16, 2021
@openjdk openjdk bot added the integrated label Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@rhalade @fguallini Since your change was applied there have been 200 commits pushed to the master branch:

  • 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
  • 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
  • 8ba390d: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • 16bd7d3: 8261336: IGV: enhance default filters
  • 3f8819c: 8261501: Shenandoah: reconsider heap statistics memory ordering
  • 3cbd16d: 8259668: Make SubTasksDone use-once
  • 219b115: 8261422: Adjust problematic String.format calls in jdk/internal/util/Preconditions.java outOfBoundsMessage
  • cdc874d: 8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0
  • e2d52ae: 8261413: Shenandoah: Disable class-unloading in I-U mode
  • 34ae7ae: 8261609: remove remnants of XML-driven builders
  • ... and 190 more: https://git.openjdk.java.net/jdk/compare/a421bfad285584430c8bd2f035ccc35b62598b17...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0a50688.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants