8351821: VMManagementImpl.c avoid switching off warnings

[MBaesken]

We switched off unused-variable warnings for the file VMManagementImpl.c, this should be avoided.
This came up in JDK-8351542 ,

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8351821: VMManagementImpl.c avoid switching off warnings (Bug - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24052/head:pull/24052
$ git checkout pull/24052

Update a local copy of the PR:
$ git checkout pull/24052
$ git pull https://git.openjdk.org/jdk.git pull/24052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24052

View PR using the GUI difftool:
$ git pr show -t 24052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24052.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351821: VMManagementImpl.c avoid switching off warnings

Reviewed-by: ihse, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 0460978: 8351096: Typos in Vector API doc
• 7f42804: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK
• 712a70c: 8318220: RISC-V: C2 ReverseI
• 985ca12: 8352011: RISC-V: Two IR tests fail after JDK-8351662
• 86b2433: 8352050: Problem list compiler/ciReplay/* test until JDK-8349191 is fixed
• 65c5282: 8351938: C2: Print compilation bailouts with PrintCompilation compile command

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following labels will be automatically applied to this pull request:

• build
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0fd8a735)

[MBaesken]

In case someone has a good/better idea what to do with the ignored returned value of
jmm_interface->GetOptionalSupport(....)
(throwing an exception? printing out something?)
we can do this of course too.

[magicus]

Build changes look good to me.

/reviewers 2

[openjdk]

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinjwalls]

We know GetOptionalSupport can't realistically fail, unless we call it with a bad pointer (we don't).
This location is called once only on startup.
We have not checked the return value since introduced in jdk5... So can't really object to not saving that value in a temp that we ignore, and simplifying the Makefile a little!

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 06289f3.
Since your change was applied there have been 6 commits pushed to the master branch:

• 0460978: 8351096: Typos in Vector API doc
• 7f42804: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK
• 712a70c: 8318220: RISC-V: C2 ReverseI
• 985ca12: 8352011: RISC-V: Two IR tests fail after JDK-8351662
• 86b2433: 8352050: Problem list compiler/ciReplay/* test until JDK-8349191 is fixed
• 65c5282: 8351938: C2: Print compilation bailouts with PrintCompilation compile command

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 06289f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.