8351970: Retire JavaLangAccess::exit

[RogerRiggs]

Cleanup the single use of JavaLangAccess.exit() it is no longer necessary; System.exit() can be called directly.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351970: Retire JavaLangAccess::exit (Enhancement - P4)

Reviewers

• Raffaello Giulietti (@rgiulietti - Reviewer)
• Chen Liang (@liach - Reviewer)
• Daniel Jeliński (@djelinski - Reviewer)

Reviewers without OpenJDK IDs

• @abdelhak-zaaim (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24066/head:pull/24066
$ git checkout pull/24066

Update a local copy of the PR:
$ git checkout pull/24066
$ git pull https://git.openjdk.org/jdk.git pull/24066/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24066

View PR using the GUI difftool:
$ git pr show -t 24066

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24066.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351970: Retire JavaLangAccess::exit

Reviewed-by: rgiulietti, liach, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 63bf791: 8351992: JFR: Improve robustness of the SettingControl examples
• 06289f3: 8351821: VMManagementImpl.c avoid switching off warnings
• 0460978: 8351096: Typos in Vector API doc
• 7f42804: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK
• 712a70c: 8318220: RISC-V: C2 ReverseI
• 985ca12: 8352011: RISC-V: Two IR tests fail after JDK-8351662
• 86b2433: 8352050: Problem list compiler/ciReplay/* test until JDK-8349191 is fixed
• 65c5282: 8351938: C2: Print compilation bailouts with PrintCompilation compile command
• e3c29c9: 8351556: Optimize Location.locationFor/isModuleOrientedLocation
• a7a09f6: 8349632: RISC-V: Add Zfa fminm/fmaxm
• ... and 1 more: https://git.openjdk.org/jdk/compare/be36b234319f1ed89ea4f4ee29471b01c1dc89f2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RogerRiggs The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (33576f3d)

[rgiulietti]

Looks fine.

[RogerRiggs]

There are other non-recoverable errors that occur in the runtime that throw InternalError or AssertionError instead of calling System.exit. Calling System.exit seems like overkill.
I did not find any discussion in the review of 8304265: Implementation of Foreign Function and Memory API with respect to that necessity. (https://git.openjdk.org/jdk/pull/13079)

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit 19154f7.
Since your change was applied there have been 28 commits pushed to the master branch:

• 3aa6d62: 8351372: Improve negative tests coverage of jpackage
• 3239919: 8350835: C2 SuperWord: assert/wrong result when using Float.float16ToFloat with byte instead of short input
• 47c1960: 8351689: -Xshare:dump with default classlist fails on static JDK
• 6b82b42: 8348598: Update Libpng to 1.6.47
• 2674a31: 8351891: Disable TestBreakSignalThreadDump.java#with_jsig and XCheckJSig.java on static JDK
• 4c6a523: 8352096: Test jdk/jfr/event/profiling/TestFullStackTrace.java shouldn't be executed with -XX:+DeoptimizeALot
• d68775d: 8351995: JFR: Leftovers from removal of Security Manager
• e62becc: 8350964: Add an ArtifactResolver.fetch(clazz) method
• dbf47d6: 8351876: RISC-V: enable and fix some float round tests
• d207ed3: 8352066: JVM.commit() and JVM.flush() exhibit race conditions against JFR epochs
• ... and 18 more: https://git.openjdk.org/jdk/compare/be36b234319f1ed89ea4f4ee29471b01c1dc89f2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit 19154f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.