8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

[manukumarvs]

Issue
java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

Reason
In MailTest.java, there is a condition check(if (!desktop.isSupported(Desktop.Action.MAIL))) which will force pass the test if the corresponding 'Action' is not supported by the platform. But, apparently, this is not working good and the code flow went past this and fails in desktop.mail() method with an UnsupportedOperationException.

Fix
Even though we are calling PassFailJFrame.forcePass() if the 'Action.MAIL' is unsupported, the PassFailJFrame just count downs a latch and the actual action will be taken later only(in awaitAndCheck()). But at the meantime, the desktop.mail() call gets executed in the constructor of MailTest() and it will result in an UnsupportedOperationException. So, the fix is to return from the constructor immediately if the operation is 'unsupported'.

Testing
This is a manual test, so it is tested locally and found to be working fine.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported (Bug - P4)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24072/head:pull/24072
$ git checkout pull/24072

Update a local copy of the PR:
$ git checkout pull/24072
$ git pull https://git.openjdk.org/jdk.git pull/24072/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24072

View PR using the GUI difftool:
$ git pr show -t 24072

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24072.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• fed34e4: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
• 8f64ccc: 8350485: C2: factor out common code in Node::grow() and Node::out_grow()
• c2be19c: 8351902: RISC-V: Several tests fail after JDK-8351145
• e57b272: 8350578: Refactor useless Parse and Template Assertion Predicate elimination code by using a PredicateVisitor
• 577ede7: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
• 20d4fe3: 8351464: Shenandoah: Hang on ShenandoahController::handle_alloc_failure when run test TestAllocHumongousFragment#generational
• 8e53063: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage
• c8a11f2: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372
• 4a02de8: 8352098: -Xrunjdwp fails on static JDK
• 355b2f3: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run
• ... and 32 more: https://git.openjdk.org/jdk/compare/0460978e7c769624cacdb528277a99914b327e30...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (650f5885)
• 01: Full - Incremental (502d659b)
• 00: Full (d2f8e394)

[manukumarvs]

Any volunteer for a review?

[lawrence-andrew]

LGTM

[aivanov-jdk]

Bump the copyright year, too.

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version 650f588) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit c7f3338.
Since your change was applied there have been 42 commits pushed to the master branch:

• fed34e4: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
• 8f64ccc: 8350485: C2: factor out common code in Node::grow() and Node::out_grow()
• c2be19c: 8351902: RISC-V: Several tests fail after JDK-8351145
• e57b272: 8350578: Refactor useless Parse and Template Assertion Predicate elimination code by using a PredicateVisitor
• 577ede7: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
• 20d4fe3: 8351464: Shenandoah: Hang on ShenandoahController::handle_alloc_failure when run test TestAllocHumongousFragment#generational
• 8e53063: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage
• c8a11f2: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372
• 4a02de8: 8352098: -Xrunjdwp fails on static JDK
• 355b2f3: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run
• ... and 32 more: https://git.openjdk.org/jdk/compare/0460978e7c769624cacdb528277a99914b327e30...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @manukumarvs Pushed as commit c7f3338.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.