8352110: [ASAN] heap-use-after-free of task->directive()->PrintCompilationOption

[sendaoYan]

Hi all,

After JDK-8351938 several tests intermittent fails, because JVM print additional message "COMPILE SKIPPED: concurrent class loading", and AddressSanitizer report 'heap-use-after-free' error.

I don't know why task->directive()->PrintCompilationOption set as true automatically. This PR remove task->directive()->PrintCompilationOption usage, and set PrintCompilation to true when receive CompileCommandEnum::PrintCompilation.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8352110

Issue

• JDK-8352110: [BACKOUT] C2: Print compilation bailouts with PrintCompilation compile command (Sub-task - P2) ⚠️ Title mismatch between PR and JBS.

Reviewers without OpenJDK IDs

• @abdelhak-zaaim (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24073/head:pull/24073
$ git checkout pull/24073

Update a local copy of the PR:
$ git checkout pull/24073
$ git pull https://git.openjdk.org/jdk.git pull/24073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24073

View PR using the GUI difftool:
$ git pr show -t 24073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24073.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (55bf15fb)
• 00: Full (2b3160b6)

[TobiHartmann]

But this will set PrintCompilation to true globally, right? The directive should only apply to a specific method.

[chhagedorn]

Yes, we only want to have it enabled for certain methods. Let's do a backout of JDK-8351938 instead to address the problems properly in a REDO.

#24074

[sendaoYan]

Okey, I think we should close this PR.