Skip to content

Conversation

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Mar 17, 2025

Due to some failures, I think it's best to backout this and address the problems properly in a REDO.

Thanks,
Christian


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352110: [BACKOUT] C2: Print compilation bailouts with PrintCompilation compile command (Sub-task - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24074/head:pull/24074
$ git checkout pull/24074

Update a local copy of the PR:
$ git checkout pull/24074
$ git pull https://git.openjdk.org/jdk.git pull/24074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24074

View PR using the GUI difftool:
$ git pr show -t 24074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24074.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2025

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352110: [BACKOUT] C2: Print compilation bailouts with PrintCompilation compile command

Reviewed-by: thartmann, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@chhagedorn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 17, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2025

Webrevs

@chhagedorn
Copy link
Member Author

Thanks for your reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

Going to push as commit e29d405.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9f8d833: 8346194: Improve G1 pre-barrier C2 cost estimate
  • 2672c40: 8351167: ZGC: Lazily initialize livemap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2025
@openjdk openjdk bot closed this Mar 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@chhagedorn Pushed as commit e29d405.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants