Skip to content

8352159: RISC-V: add more zfa support#24081

Closed
Hamlin-Li wants to merge 6 commits intoopenjdk:masterfrom
Hamlin-Li:add-zfa-float16
Closed

8352159: RISC-V: add more zfa support#24081
Hamlin-Li wants to merge 6 commits intoopenjdk:masterfrom
Hamlin-Li:add-zfa-float16

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Mar 17, 2025

Hi,
Can you help to review this patch?

Previously in #23844, loadConH is implemented only with flh, but fli_h should be more efficient if Zfa is supported; min/max for HF could use fmin/maxm.h instead too.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352159: RISC-V: add more zfa support (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24081/head:pull/24081
$ git checkout pull/24081

Update a local copy of the PR:
$ git checkout pull/24081
$ git pull https://git.openjdk.org/jdk.git pull/24081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24081

View PR using the GUI difftool:
$ git pr show -t 24081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24081.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2025

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352159: RISC-V: add more zfa support

Reviewed-by: fyang, luhenry, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
  • 07667ca: 8352506: Simplify make/test/JtregNativeHotspot.gmk
  • b545b9e: 8352584: [Backout] G1: Pinned regions with pinned objects only reachable by native code crash VM
  • 1c0fa0a: 8352512: TestVectorZeroCount: counter not reset between iterations
  • 466f82a: 8314999: IR framework fails to detect allocation
  • 06ba6cf: 8329173: LCMS_CFLAGS from configure are lost
  • 56038fb: 8352317: Assertion failure during size estimation of BoxLockNode with -XX:+UseAPX
  • 2bc4f64: 8335708: C2: Compile::verify_graph_edges must start at root and safepoints, just like CCP traversal
  • 9a17a6f: 8350749: Upgrade JLine to 3.29.0
  • 91836e1: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK
  • ... and 26 more: https://git.openjdk.org/jdk/compare/b891bfa7e67c21478475642e2bfa2cdc65a3bffe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 17, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2025

Webrevs

@Hamlin-Li Hamlin-Li changed the title 8352159: RISC-V: add zfa support for loadConH 8352159: RISC-V: add more zfa support Mar 17, 2025
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have a suggestion about the value searching. We can consider that in the future.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 19, 2025
@Hamlin-Li
Copy link
Author

Looks good to me. I have a suggestion about the value searching. We can consider that in the future.

Thank you!

Copy link
Contributor

@robehn robehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good, thanks!

@Hamlin-Li
Copy link
Author

Thank you @luhenry @robehn !

@Hamlin-Li
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2025

Going to push as commit 04eac0c.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2025
@openjdk openjdk bot closed this Mar 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2025
@Hamlin-Li Hamlin-Li deleted the add-zfa-float16 branch March 21, 2025 12:10
@openjdk
Copy link

openjdk bot commented Mar 21, 2025

@Hamlin-Li Pushed as commit 04eac0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants