8344671: Few JFR streaming tests fail with application not alive error on MacOS 15

[larry-cable]

on both Linux and MacOS libattach utilizes UNIX signal (QUIT) to cause a target JVM (attachee) to create the socket file used as transport for subsequent jcmds (and other attach based interactions) and to listen upon that for such.

it should be noted that the default behavior for QUIT (if not blocked or caught) is to terminate the signalled process.

during the early lifetime of a JVM, its signal handlers are not yet installed, and thus any signal such as QUIT will cause the
default behavior to occur, in this case the JVM will be terminated.

this is why some tests are failing with "not alive"

the "fix" is similar in nature to that already implemented for linux (however using a different OS dependent mechanism to obtain the attachee JVM's signal masks: sysctl(2)).

the method "checkCatchesAndSendQuitTo" will now obtain the "attachee" JVM signal masks and only kill(QUIT) if the
current masks indicate that the JVM's signals are now being handled.

the behavior in the success case is now identical to the previous implementation, however should the target JVM not
become "ready" (signal handlers installed) prior to the attach "timeout" occurring the attach operation will throw an
"AttachNotSupportedException" with a suitable error message.

see also: https://bugs.openjdk.org/browse/JDK-8350766

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24085/head:pull/24085
$ git checkout pull/24085

Update a local copy of the PR:
$ git checkout pull/24085
$ git pull https://git.openjdk.org/jdk.git pull/24085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24085

View PR using the GUI difftool:
$ git pr show -t 24085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24085.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back larry-cable! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@larry-cable This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344671: Few JFR streaming tests fail with application not alive error on MacOS 15

Reviewed-by: dholmes, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 252 new commits pushed to the master branch:

• 49cb7aa: 8339114: DaCapo xalan performance with -XX:+UseObjectMonitorTable
• d32ff13: 8353117: Crash: assert(id >= ThreadIdentifier::initial() && id < ThreadIdentifier::current()) failed: must be reasonable)
• a0677d9: 8353263: Parallel: Remove locking in PSOldGen::resize
• 8608b16: 8348887: Create IR framework test for JDK-8347997
• 23eb648: 8353545: Improve debug info for StartOptionTest
• 4f97c4c: 8349211: Add support for intrusive trees to the utilities red-black tree
• c9baa8a: 8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead
• b80b04d: 8353329: Small memory leak when create GrowableArray with initial size 0
• 4a50778: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS
• 9076673: 8304674: File java.c compile error with -fsanitize=address -O0
• ... and 242 more: https://git.openjdk.org/jdk/compare/0460978e7c769624cacdb528277a99914b327e30...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @kevinjwalls) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@larry-cable The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dholmes-ora]

Thanks very much for fixing this @larry-cable ! Changes look good. Just a few minor nits.

[dholmes-ora]

Also you need to remove the ProblemList entries in test/jdk/ProblemList.txt.

[jaikiran]

jcheck is complaining about some whitespace errors in this PR which is why the RFR email hasn't yet been generated.

[jaikiran]

Hello Larry, there are a few more whitespace issues that's preventing a RFR from being intiated.

[mlbridge]

Webrevs

• 04: Full - Incremental (c27af72a)
• 03: Full - Incremental (9b81d337)
• 02: Full - Incremental (acd32c1a)
• 01: Full - Incremental (b2f465e4)
• 00: Full (00161668)

[jaikiran]

I'm guessing it's not going to be easy to introduce a regression test for this change. If so, then the linked JDK issue will need a noreg label (likely noreg-hard).

[openjdk]

⚠️ @larry-cable This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[dholmes-ora]

Looks good. Just a couple of remaining nits. Thanks.

[larry-cable]

/integrate

[openjdk]

@larry-cable This pull request has not yet been marked as ready for integration.

[dholmes-ora]

Okay

[kevinjwalls]

Looks good.

(I'm sure the Linux and MacOS VirtualMachineImpl() attach/timeout loops are almost identical now, not a problem but maybe one day we can de-duplicate them.)

[kevinjwalls]

/integrate

[openjdk]

@kevinjwalls Only the author (@larry-cable) is allowed to issue the integrate command.

[kevinjwalls]

/sponsor

[openjdk]

@kevinjwalls The change author (@larry-cable) must issue an integrate command before the integration can be sponsored.

[larry-cable]

/integrate

[openjdk]

@larry-cable
Your change (at version c27af72) is now ready to be sponsored by a Committer.

[kevinjwalls]

/sponsor

[openjdk]

Going to push as commit d979bd8.
Since your change was applied there have been 252 commits pushed to the master branch:

• 49cb7aa: 8339114: DaCapo xalan performance with -XX:+UseObjectMonitorTable
• d32ff13: 8353117: Crash: assert(id >= ThreadIdentifier::initial() && id < ThreadIdentifier::current()) failed: must be reasonable)
• a0677d9: 8353263: Parallel: Remove locking in PSOldGen::resize
• 8608b16: 8348887: Create IR framework test for JDK-8347997
• 23eb648: 8353545: Improve debug info for StartOptionTest
• 4f97c4c: 8349211: Add support for intrusive trees to the utilities red-black tree
• c9baa8a: 8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead
• b80b04d: 8353329: Small memory leak when create GrowableArray with initial size 0
• 4a50778: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS
• 9076673: 8304674: File java.c compile error with -fsanitize=address -O0
• ... and 242 more: https://git.openjdk.org/jdk/compare/0460978e7c769624cacdb528277a99914b327e30...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls @larry-cable Pushed as commit d979bd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mrserb]

I’m just curious - why does this method return a boolean? It looks like the result is never actually checked, and the control flow is managed through exceptions or errors(on both linux and macos).