Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 18, 2025

Fix a typo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

Issue

  • JDK-8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24101/head:pull/24101
$ git checkout pull/24101

Update a local copy of the PR:
$ git checkout pull/24101
$ git pull https://git.openjdk.org/jdk.git pull/24101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24101

View PR using the GUI difftool:
$ git pr show -t 24101

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24101.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 4a02de8: 8352098: -Xrunjdwp fails on static JDK
  • 355b2f3: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run
  • a3540be: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055
  • 53c5b93: 8352180: AttachListenerThread causes many tests to timeout on Windows
  • b025d8c: 8350663: AArch64: Enable UseSignumIntrinsic by default
  • a37d843: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings
  • b891bfa: 8352022: RISC-V: Support Zfa fminm_h/fmaxm_h for float16
  • 20f1bca: 8351187: Add JFR monitor notification event
  • 46b3d1d: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing
  • 558c015: 8351921: G1: Pinned regions with pinned objects only reachable by native code crash VM
  • ... and 4 more: https://git.openjdk.org/jdk/compare/19154f7af34bf6f13d61d7a9f05d6277964845d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2025
@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 18, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2025

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev PTAL

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 18, 2025
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

Going to push as commit c8a11f2.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 4a02de8: 8352098: -Xrunjdwp fails on static JDK
  • 355b2f3: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run
  • a3540be: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055
  • 53c5b93: 8352180: AttachListenerThread causes many tests to timeout on Windows
  • b025d8c: 8350663: AArch64: Enable UseSignumIntrinsic by default
  • a37d843: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings
  • b891bfa: 8352022: RISC-V: Support Zfa fminm_h/fmaxm_h for float16
  • 20f1bca: 8351187: Add JFR monitor notification event
  • 46b3d1d: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing
  • 558c015: 8351921: G1: Pinned regions with pinned objects only reachable by native code crash VM
  • ... and 4 more: https://git.openjdk.org/jdk/compare/19154f7af34bf6f13d61d7a9f05d6277964845d8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2025
@openjdk openjdk bot closed this Mar 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2025
@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@alexeysemenyukoracle Pushed as commit c8a11f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants