8352428: GenShen: Old-gen cycles are still looping

[kdnilsen]

A recent commit failed to address all paths by which an infinite loop of old GC cycles might occur. This new PR handles one other case related to the original problem. This is part2 of the fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352428: GenShen: Old-gen cycles are still looping (Bug - P4)

Reviewers

• William Kemper (@earthling-amzn - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24106/head:pull/24106
$ git checkout pull/24106

Update a local copy of the PR:
$ git checkout pull/24106
$ git pull https://git.openjdk.org/jdk.git pull/24106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24106

View PR using the GUI difftool:
$ git pr show -t 24106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24106.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352428: GenShen: Old-gen cycles are still looping

Reviewed-by: wkemper, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• ac3ad03: 8350589: Investigate cleaner implementation of AArch64 ML-DSA intrinsic introduced in JDK-8348561
• 8a1c85e: 8350898: Shenandoah: Eliminate final roots safepoint
• 8e999b8: 8351969: Add Public Identifiers to the JDK built-in Catalog
• c7f3338: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported
• fed34e4: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
• 8f64ccc: 8350485: C2: factor out common code in Node::grow() and Node::out_grow()
• c2be19c: 8351902: RISC-V: Several tests fail after JDK-8351145
• e57b272: 8350578: Refactor useless Parse and Template Assertion Predicate elimination code by using a PredicateVisitor
• 577ede7: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
• 20d4fe3: 8351464: Shenandoah: Hang on ShenandoahController::handle_alloc_failure when run test TestAllocHumongousFragment#generational
• ... and 2 more: https://git.openjdk.org/jdk/compare/4a02de82923545f18590f8509c55129a4aa20842...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kdnilsen The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4ebb3aaf)

[earthling-amzn]

LGTM

[shipilev]

I don't understand the bug mapping here. JDK-8350889 is already resolved. I think you need to file a follow-up bug and reference that new bug in this PR.

[kdnilsen]

Thanks @shipilev for your suggestion. I've opened another JBS issue and linked this new PR to that.

[shipilev]

Looks fine to me.

Note the are useful "Caused by" and "Related" links in JBS, which you should really use to track the dependencies between the tickets. I added some, see how it looks. Also, these are either "Enhancement" or "Bug". "Task" is usually about something that is not code-related: https://openjdk.org/guide/#types-of-issues

[kdnilsen]

/integrate

[openjdk]

Going to push as commit 74df384.
Since your change was applied there have been 13 commits pushed to the master branch:

• fcc2a24: 8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError
• ac3ad03: 8350589: Investigate cleaner implementation of AArch64 ML-DSA intrinsic introduced in JDK-8348561
• 8a1c85e: 8350898: Shenandoah: Eliminate final roots safepoint
• 8e999b8: 8351969: Add Public Identifiers to the JDK built-in Catalog
• c7f3338: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported
• fed34e4: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
• 8f64ccc: 8350485: C2: factor out common code in Node::grow() and Node::out_grow()
• c2be19c: 8351902: RISC-V: Several tests fail after JDK-8351145
• e57b272: 8350578: Refactor useless Parse and Template Assertion Predicate elimination code by using a PredicateVisitor
• 577ede7: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
• ... and 3 more: https://git.openjdk.org/jdk/compare/4a02de82923545f18590f8509c55129a4aa20842...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kdnilsen Pushed as commit 74df384.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.