Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242300: SystemDictionary::resolve_super_or_fail() should look for the super class first #2411

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Feb 4, 2021

Fixed CDS to do a find() before calling resolve_super_or_null as an optimization. See numbers in the CR for details.
Tested with tier1-8 (2 jobs in 8 still running).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242300: SystemDictionary::resolve_super_or_fail() should look for the super class first

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2411/head:pull/2411
$ git checkout pull/2411

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2021
@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 4, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2021

Webrevs

iklam
iklam approved these changes Feb 5, 2021
Copy link
Member

@iklam iklam left a comment

Looks good to me!

@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8242300: SystemDictionary::resolve_super_or_fail() should look for the super class first

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c5bb109: 8260019: Move some Thread subtypes out of thread.hpp
  • 08f7454: 8261190: restore original Alibaba copyright line in two files
  • 3bb6a3d: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2021
Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good.

@coleenp
Copy link
Contributor Author

coleenp commented Feb 5, 2021

Thanks Ioi and Calvin!
/integrate

@openjdk openjdk bot closed this Feb 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@coleenp Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f9df366.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the super-opt branch Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants