Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261179: Norwegian Bokmål Locale fallback issue #2414

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Feb 4, 2021

Please review this fix. The bug was revealed while porting CLDR v39 into the JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some regression tests started failing with it because COMPAT provider's "nb" resource was used according to the incorrect candidate locale order.

[1] https://unicode-org.atlassian.net/browse/CLDR-2698


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2414/head:pull/2414
$ git checkout pull/2414

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Feb 4, 2021
@naotoj
Copy link
Member Author

naotoj commented Feb 4, 2021

/label i18n

@openjdk openjdk bot added the i18n label Feb 4, 2021
@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@naotoj
The i18n label was successfully added.

@naotoj naotoj marked this pull request as ready for review Feb 4, 2021
@openjdk openjdk bot added the rfr label Feb 4, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261179: Norwegian Bokmål Locale fallback issue

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 08f7454: 8261190: restore original Alibaba copyright line in two files

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 5, 2021
@naotoj
Copy link
Member Author

naotoj commented Feb 5, 2021

/integrate

@openjdk openjdk bot closed this Feb 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@naotoj Since your change was applied there have been 13 commits pushed to the master branch:

  • 0218917: 8258732: runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java fails
  • f9df366: 8242300: SystemDictionary::resolve_super_or_fail() should look for the super class first
  • 43ae0cf: 8261167: print_process_memory_info add a close call after fopen
  • 48f5220: 8260369: [PPC64] Add support for JDK-8200555
  • 224c166: 8261213: [BACKOUT] MutableSpace's end should be atomic
  • 3495feb: 8260296: SA's dumpreplaydata fails
  • 0791899: 8261154: Memory leak in Java_java_lang_ClassLoader_defineClass0 with long class names
  • 78b0d32: 8234534: Simplify CardTable code after CMS removal
  • ee2f205: 8260926: Trace resource exhausted events unconditionally
  • 1e0a101: 8259862: MutableSpace's end should be atomic
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/3bb6a3d2ab96373baa4e18f4e61173f11225fd4e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4a1814c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@naotoj naotoj deleted the JDK-8261179 branch Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs i18n integrated
2 participants