Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261190: restore original Alibaba copyright line in two files #2417

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 4, 2021

A trivial fix to restore original Alibaba copyright line in two files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261190: restore original Alibaba copyright line in two files

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2417/head:pull/2417
$ git checkout pull/2417

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@dcubed-ojdk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Feb 4, 2021
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Feb 4, 2021

/label hotspot-runtime hotspot-jfr

@dholmes-ora, @egahlin and @D-D-H - Would love for the three
of you to chime in on this one.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Feb 4, 2021
@openjdk openjdk bot added rfr hotspot-runtime hotspot-jfr labels Feb 4, 2021
@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

The hotspot-jfr label was successfully added.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Feb 4, 2021

The validate-source task in Mach5 Tier1 has passed.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good and trivial.

Thanks,
David

@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261190: restore original Alibaba copyright line in two files

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 4, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Feb 4, 2021

/integrate

@openjdk openjdk bot closed this Feb 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 4, 2021
@openjdk
Copy link

openjdk bot commented Feb 4, 2021

@dcubed-ojdk Pushed as commit 08f7454.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Feb 4, 2021

@dholmes-ora - Thanks for the fast review.
@egahlin and @D-D-H - please chime in to confirm that you've seen this thread.
@D-D-H - please read my comments in:
JDK-8261190: restore original Alibaba copyright line in two files
so that you know what had to change with your original copyright headers.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8261190 branch Feb 4, 2021
@D-D-H
Copy link
Contributor

D-D-H commented Feb 5, 2021

@dholmes-ora - Thanks for the fast review.
@egahlin and @D-D-H - please chime in to confirm that you've seen this thread.
@D-D-H - please read my comments in:
JDK-8261190: restore original Alibaba copyright line in two files
so that you know what had to change with your original copyright headers.

There is a problem with the copyright format we used before, thank you for your correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-jfr hotspot-runtime integrated
3 participants