Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code #2418

Closed
wants to merge 1 commit into from
Closed

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Feb 5, 2021

we need to specify ()I for the signature of the method that returns int.
Additionally number (the instance!) needs to be passed to the method up call.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2418/head:pull/2418
$ git checkout pull/2418

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 5, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@prrace The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Feb 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 5, 2021

Webrevs

@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 5, 2021

/label add swing

@openjdk openjdk bot added the swing label Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@prrace
The swing label was successfully added.

mrserb
mrserb approved these changes Feb 5, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@prrace This PR has not yet been marked as ready for integration.

@prrace prrace changed the title 8261198: [macOS] Incorrect JNI parameters in number conversion in A1Y code. 8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code Feb 5, 2021
@prrace
Copy link
Contributor Author

@prrace prrace commented Feb 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 4a1814c: 8261179: Norwegian Bokmål Locale fallback issue
  • 0218917: 8258732: runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java fails
  • f9df366: 8242300: SystemDictionary::resolve_super_or_fail() should look for the super class first
  • 43ae0cf: 8261167: print_process_memory_info add a close call after fopen
  • 48f5220: 8260369: [PPC64] Add support for JDK-8200555
  • 224c166: 8261213: [BACKOUT] MutableSpace's end should be atomic
  • 3495feb: 8260296: SA's dumpreplaydata fails
  • 0791899: 8261154: Memory leak in Java_java_lang_ClassLoader_defineClass0 with long class names
  • 78b0d32: 8234534: Simplify CardTable code after CMS removal
  • ee2f205: 8260926: Trace resource exhausted events unconditionally
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/08f7454fa961e00f9f5ec370a339ae89134dcbf6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 5, 2021
@openjdk openjdk bot closed this Feb 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@prrace Since your change was applied there have been 13 commits pushed to the master branch:

  • 4a1814c: 8261179: Norwegian Bokmål Locale fallback issue
  • 0218917: 8258732: runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java fails
  • f9df366: 8242300: SystemDictionary::resolve_super_or_fail() should look for the super class first
  • 43ae0cf: 8261167: print_process_memory_info add a close call after fopen
  • 48f5220: 8260369: [PPC64] Add support for JDK-8200555
  • 224c166: 8261213: [BACKOUT] MutableSpace's end should be atomic
  • 3495feb: 8260296: SA's dumpreplaydata fails
  • 0791899: 8261154: Memory leak in Java_java_lang_ClassLoader_defineClass0 with long class names
  • 78b0d32: 8234534: Simplify CardTable code after CMS removal
  • ee2f205: 8260926: Trace resource exhausted events unconditionally
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/08f7454fa961e00f9f5ec370a339ae89134dcbf6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4a89733.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the number branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants