-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code #2418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
/label add swing |
@prrace |
/integrate |
@prrace This PR has not yet been marked as ready for integration. |
/integrate |
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@prrace Since your change was applied there have been 13 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4a89733. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
we need to specify ()I for the signature of the method that returns int.
Additionally number (the instance!) needs to be passed to the method up call.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2418/head:pull/2418
$ git checkout pull/2418