-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8352738: Implement JEP 520: JFR Method Timing and Tracing #24205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
/label remove serviceability |
|
@egahlin |
|
/label add hotspot-jfr |
|
@egahlin |
|
Are the suboptions/parameters specified to -XX:StartFlightRecording a supported interface that is tracked by the CSR? I'm just wondering about the method-timing review specified to report-on-exit for example. |
|
@egahlin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
/contributor add @mgronlun |
|
@egahlin |
|
@egahlin this pull request can not be integrated into git checkout method-timing-and-tracing
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Could I have a review of this enhancement that will add tracing capabilities to JFR? There are opportunities for performance improvements in the implementation, but I would rather add them later and separately.
Testing: tier 1-3, test/jdk/jdk/jfr
Thanks
Erik
Progress
Error
Issues
Contributors
<mgronlun@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24205/head:pull/24205$ git checkout pull/24205Update a local copy of the PR:
$ git checkout pull/24205$ git pull https://git.openjdk.org/jdk.git pull/24205/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24205View PR using the GUI difftool:
$ git pr show -t 24205Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24205.diff
Using Webrev
Link to Webrev Comment