Skip to content

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Mar 24, 2025

Could I have a review of this enhancement that will add tracing capabilities to JFR? There are opportunities for performance improvements in the implementation, but I would rather add them later and separately.

Testing: tier 1-3, test/jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Error

 ⚠️ This PR contains no changes

Issues

  • JDK-8352738: Implement JEP 520: JFR Method Timing and Tracing (Enhancement - P2)
  • JDK-8356994: Implement JEP 520: JFR Method Timing and Tracing (CSR)

Contributors

  • Markus Grönlund <mgronlun@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24205/head:pull/24205
$ git checkout pull/24205

Update a local copy of the PR:
$ git checkout pull/24205
$ git pull https://git.openjdk.org/jdk.git pull/24205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24205

View PR using the GUI difftool:
$ git pr show -t 24205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24205.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@egahlin The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Mar 24, 2025
@egahlin
Copy link
Member Author

egahlin commented Mar 25, 2025

/label remove serviceability

@openjdk openjdk bot removed the serviceability serviceability-dev@openjdk.org label Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@egahlin
The serviceability label was successfully removed.

@egahlin
Copy link
Member Author

egahlin commented Mar 25, 2025

/label add hotspot-jfr

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@egahlin
The hotspot-jfr label was successfully added.

@egahlin egahlin marked this pull request as ready for review March 26, 2025 10:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2025

Webrevs

@AlanBateman
Copy link
Contributor

Are the suboptions/parameters specified to -XX:StartFlightRecording a supported interface that is tracked by the CSR? I'm just wondering about the method-timing review specified to report-on-exit for example.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2025

@egahlin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@egahlin egahlin marked this pull request as draft April 24, 2025 15:43
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 24, 2025
@egahlin
Copy link
Member Author

egahlin commented Apr 24, 2025

/contributor add @mgronlun

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@egahlin
Contributor Markus Grönlund <mgronlun@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented May 14, 2025

@egahlin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout method-timing-and-tracing
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch csr Pull request needs approved CSR before integration labels May 14, 2025
erik_gahlin added 2 commits May 15, 2025 15:36
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label May 15, 2025
@egahlin egahlin changed the title 8352738: JFR: Implementation of JFR Method Timing and Tracing 8352738: Implement JEP 520: JFR Method Timing and Tracing May 19, 2025
@egahlin egahlin closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csr Pull request needs approved CSR before integration hotspot hotspot-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants