8310310: Migrate CreateSymbols tool in make/langtools to Classfile API

[liach]

Migrates the CreateSymbols tool to use the ClassFile API, away from com.sun.tools.classfile.

Need the boot jdk --with-boot-jdk= to be 24; thus a draft for now; but this is open to reviews.

Together with #24206, the old com.sun.tools.classfile can be removed from the JDK.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8310310: Migrate CreateSymbols tool in make/langtools to Classfile API (Sub-task - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24212/head:pull/24212
$ git checkout pull/24212

Update a local copy of the PR:
$ git checkout pull/24212
$ git pull https://git.openjdk.org/jdk.git pull/24212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24212

View PR using the GUI difftool:
$ git pr show -t 24212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24212.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310310: Migrate CreateSymbols tool in make/langtools to Classfile API

Reviewed-by: ihse, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• c3e0439: 8354121: Use a record class rather than a lambda in AbstractMemorySegmentImpl::cleanupAction
• 9d8b93b: 8354181: [Backout] 8334046: Set different values for CompLevel_any and CompLevel_all
• da462cf: 8353692: Relax memory constraint on updating ObjectMonitorTable's item count
• ... and 20 more: https://git.openjdk.org/jdk/compare/5b42c46b48363acd00ee4a183edca9a48cdc16c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following labels will be automatically applied to this pull request:

• build
• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e3d1a4ea)
• 00: Full (df57ca1e)

[archiecobbs]

Refactoring awesomeness ratio:

1011 deletions
357 additions
RAR: 2.83

Impressive :)

[liach]

No worries - we will delete the whole com.sun.tools.classfile package, which will be another 10k+ lines removed 😉

[liach]

@nizarbenalla Can you help run CreateSymbols from this patch and compare the results with baseline?

[nizarbenalla]

I compared the results with baseline a few times and they seem identical.
I checked out the JDK repo at an earlier point and followed the same steps I used to create #22867 and the result was identical.

Great work!

[liach]

Tests tier 1-3 all pass (except a tier 2 test already fixed by 8353945)

[magicus]

Build changes look trivially fine.

/reviewers 2

[openjdk]

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[liach]

/reviewers 2 reviewer

[openjdk]

@liach
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[lahodaj]

I skimmed through the CreateSymbols changes, used test/langtools/tools/javac/sym/PrintCTSymContent.java to print ct.sym content before and after, and let the tool that generates the .sym.txt to run for JDK 24. All seems fine to me. Thanks!

[liach]

Thanks Nizar, Jan, and Magnus for the reviews!

/integrate

[openjdk]

Going to push as commit 4dc9e58.
Since your change was applied there have been 24 commits pushed to the master branch:

• 7a7b9ed: 8353727: HeapDumpPath doesn't expand %p
• c3e0439: 8354121: Use a record class rather than a lambda in AbstractMemorySegmentImpl::cleanupAction
• 9d8b93b: 8354181: [Backout] 8334046: Set different values for CompLevel_any and CompLevel_all
• ... and 21 more: https://git.openjdk.org/jdk/compare/5b42c46b48363acd00ee4a183edca9a48cdc16c8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 4dc9e58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.