Skip to content

8352676: Opensource JMenu tests - series1#24220

Closed
prsadhuk wants to merge 1 commit intoopenjdk:masterfrom
prsadhuk:JDK-8352676
Closed

8352676: Opensource JMenu tests - series1#24220
prsadhuk wants to merge 1 commit intoopenjdk:masterfrom
prsadhuk:JDK-8352676

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 25, 2025

Few JMenu tests are opensourced


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352676: Opensource JMenu tests - series1 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24220/head:pull/24220
$ git checkout pull/24220

Update a local copy of the PR:
$ git checkout pull/24220
$ git pull https://git.openjdk.org/jdk.git pull/24220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24220

View PR using the GUI difftool:
$ git pr show -t 24220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24220.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352676: Opensource JMenu tests - series1

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • 3d3b782: 8352607: RISC-V: use cmove in min/max when Zicond is supported
  • 9f582e5: 8320997: RISC-V: C2 ReverseV
  • 6879c44: 8351405: G1: Collection set early pruning causes suboptimal region selection
  • aee4d69: 8348829: Remove ObjectMonitor perf counters
  • f9bcef4: 8351627: C2 AArch64 ROR/ROL: assert((1 << ((T>>1)+3)) > shift) failed: Invalid Shift value
  • 17dc30c: 8352414: JFR: JavaMonitorDeflateEvent crashes when deflated monitor object is dead
  • 6bc4803: 8351277: Remove pipewire from AIX build
  • c94bc74: 8352595: Regression of JDK-8314999 in IR matching
  • 48fac66: 8347406: [REDO] C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
  • 99c8a6e: 8350463: AArch64: Add vector rearrange support for small lane count vectors
  • ... and 47 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2025
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

Going to push as commit c002b97.
Since your change was applied there have been 58 commits pushed to the master branch:

  • bdcac98: 8347459: C2: missing transformation for chain of shifts/multiplications by constants
  • 3d3b782: 8352607: RISC-V: use cmove in min/max when Zicond is supported
  • 9f582e5: 8320997: RISC-V: C2 ReverseV
  • 6879c44: 8351405: G1: Collection set early pruning causes suboptimal region selection
  • aee4d69: 8348829: Remove ObjectMonitor perf counters
  • f9bcef4: 8351627: C2 AArch64 ROR/ROL: assert((1 << ((T>>1)+3)) > shift) failed: Invalid Shift value
  • 17dc30c: 8352414: JFR: JavaMonitorDeflateEvent crashes when deflated monitor object is dead
  • 6bc4803: 8351277: Remove pipewire from AIX build
  • c94bc74: 8352595: Regression of JDK-8314999 in IR matching
  • 48fac66: 8347406: [REDO] C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
  • ... and 48 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2025
@openjdk openjdk bot closed this Mar 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@prsadhuk Pushed as commit c002b97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8352676 branch March 25, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants