Skip to content

8348853: Fold layout helper check for objects implementing non-array interfaces #24245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

8348853: Fold layout helper check for objects implementing non-array interfaces #24245

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bf3f27
Generalize the not-array proof
marc-chevalier Mar 20, 2025
a77c397
Revert now useless fix
marc-chevalier Mar 21, 2025
daaaf9a
not reinventing the wheel
marc-chevalier Mar 31, 2025
0467722
Merge branch 'master' into feat/Fold-layout-helper-check-for-objects-…
marc-chevalier Apr 8, 2025
b1fb82a
Merge branch 'master' into feat/Fold-layout-helper-check-for-objects-…
marc-chevalier Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/hotspot/share/opto/type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3684,19 +3684,7 @@ bool TypeInterfaces::singleton(void) const {
bool TypeInterfaces::has_non_array_interface() const {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using TypeAryPtr::_array_interfaces->contains(_interfaces); instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost!

return !TypeAryPtr::_array_interfaces->contains(this);

Contains is about TypeInterfaces, that is set of interfaces. So I just need to check that this is not a sub-set of array interfaces. That should do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm confused, isn't this what I proposed? I didn't check the exact syntax, I just wondered if the TypeInterfaces::contains method couldn't be used instead of adding a new method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, totally! It's just a detail difference. But there is another question: whether we still want has_non_array_interface has a wrapper for this call with a more explicit name, or if we simply inline your suggestion on the callsite of has_non_array_interface. I tend toward the first, I like explicit names, and I suspect it might be useful in more than one place, but not a strong opinion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I just replaced the implementation of has_non_array_interface. If one feels even keeping the method is premature factorization, I can easily inline it.

assert(TypeAryPtr::_array_interfaces != nullptr, "How come Type::Initialize_shared wasn't called yet?");

for (const ciInstanceKlass* interface : _interfaces) {
bool is_an_array_interface = false;
for (const ciInstanceKlass* array_interface : TypeAryPtr::_array_interfaces->_interfaces) {
if (interface->equals(array_interface)) {
is_an_array_interface = true;
}
}
if (!is_an_array_interface) {
return true;
}
}

return false;
return !TypeAryPtr::_array_interfaces->contains(this);
}

//------------------------------TypeOopPtr-------------------------------------
Expand Down