8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2

[gredler]

Win32ShellFolderManager2 contains a check as to whether the current Windows version is Windows 2000 or later. The current minimum supported version is Windows 10, so this is no longer needed.

No test seems to currently exercise this code, and it's not easy to reliably test, but I've added a basic test that should surface any fundamental issues. The change is very simple, though.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2 (Bug - P5)

Reviewers

• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24256/head:pull/24256
$ git checkout pull/24256

Update a local copy of the PR:
$ git checkout pull/24256
$ git pull https://git.openjdk.org/jdk.git pull/24256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24256

View PR using the GUI difftool:
$ git pr show -t 24256

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24256.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gredler This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 548 new commits pushed to the master branch:

• cfc648b: 8352677: Opensource JMenu tests - series2
• 2ea1557: 8353005: AIX build broken after 8352481
• f4428e8: 8352920: Compilation failure: comparison of unsigned expression >= 0 is always true
• d5b12c8: 8352890: Remove unnecessary Windows version check in FileFontStrike
• 58ef401: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter
• 4ce9b4c: 8352435: Refactor CDS test library for execution and module packaging
• b73663a: 8351155: C1/C2: Remove 32-bit x86 specific FP rounding support
• 1bd0ce1: 8352918: Shenandoah: Verifier does not deactivate barriers as intended
• dc5c414: 8352762: Use EXACTFMT instead of expanded version where applicable
• 2eeda64: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log
• ... and 538 more: https://git.openjdk.org/jdk/compare/55097dd4cbb5d691c12cb0247d66dce593759d59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@gredler The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3409da27)
• 00: Full (e802646e)

[prrace]

testing looks good

[gredler]

@prr Just to verify, was the testing for this one or for #24230?

[prrace]

@prr Just to verify, was the testing for this one or for #24230?

oops wrong PR. I'll submit a test job for this one soon.

[prrace]

So testing for this PR looks good.

[gredler]

/integrate

[openjdk]

@gredler
Your change (at version 3409da2) is now ready to be sponsored by a Committer.

[mrserb]

/sponsor

[openjdk]

Going to push as commit 3d2c3cd.
Since your change was applied there have been 558 commits pushed to the master branch:

• c70ad6a: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call
• da3bb06: 8352685: Opensource JInternalFrame tests - series2
• d809033: 8341775: Duplicate manifest files are removed by jarsigner after signing
• a269bef: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64
• c029220: 8352896: LambdaExpr02.java runs wrong test class
• c0b61d3: 8352680: Opensource few misc swing tests
• 3e9a7a4: 8353063: make/ide/vscode: Invalid Configuration Values
• 8ef7832: 8350471: Unhandled compilation bailout in GraphKit::builtin_throw
• ddf326b: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
• bac2aa4: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table
• ... and 548 more: https://git.openjdk.org/jdk/compare/55097dd4cbb5d691c12cb0247d66dce593759d59...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb @gredler Pushed as commit 3d2c3cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.