8344116: C2: remove slice parameter from LoadNode::make

[linzihao1999]

This patch remove slice parameter from LoadNode::make

Mention in #21834 (review)

Hi team, I am new, I'd appreciate any guidance. Thank a lot!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344116: C2: remove slice parameter from LoadNode::make (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24258/head:pull/24258
$ git checkout pull/24258

Update a local copy of the PR:
$ git checkout pull/24258
$ git pull https://git.openjdk.org/jdk.git pull/24258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24258

View PR using the GUI difftool:
$ git pr show -t 24258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24258.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back linzihao1999! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@linzihao1999 The following labels will be automatically applied to this pull request:

• graal
• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (ea83736e)
• 05: Full - Incremental (3efb1c17)
• 04: Full - Incremental (a1924c35)
• 03: Full - Incremental (f6b2fbec)
• 02: Full - Incremental (08c1a382)
• 01: Full - Incremental (f4ef46dc)
• 00: Full (27df4a01)

[chhagedorn]

/label add hotspot-compiler

[openjdk]

@chhagedorn
The hotspot-compiler label was successfully added.

[openjdk]

@linzihao1999 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[linzihao1999]

Hi @TobiHartmann , Could you please take a look? Thank you.

[TobiHartmann]

I think @rwestrel should have a look at this, since he suggested the cleanup in #21834.

[rwestrel]

Can we get rid of all uses of access.addr().type()?

[rwestrel]

We could asssert that C->get_alias_index(kit->type(card_adr) == Compile::AliasIdxRaw, that is that computed slice is the same as hardcoded slide. Similar asserts could be added for every location where a slice/address type is removed in this patch.

[bridgekeeper]

@linzihao1999 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@linzihao1999 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.