Skip to content

8344116: C2: remove slice parameter from LoadNode::make #24258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+40 −51
Closed

8344116: C2: remove slice parameter from LoadNode::make #24258

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6b2fbe
8344116: C2: remove slice parameter from LoadNode::make
linzihao1999 Mar 26, 2025
74a4435
Fix test failed
linzihao1999 Mar 28, 2025
a1924c3
Fix build
linzihao1999 Mar 28, 2025
3efb1c1
Merge branch 'openjdk:master' into 8344116
linzihao1999 Apr 5, 2025
ea83736
Merge branch 'openjdk:master' into 8344116
linzihao1999 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/shared/c2/barrierSetC2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ Node* BarrierSetC2::load_at_resolved(C2Access& access, const Type* val_type) con
Node* control = control_dependent ? opt_access.ctl() : nullptr;
MergeMemNode* mm = opt_access.mem();
PhaseGVN& gvn = opt_access.gvn();
Node* mem = mm->memory_at(gvn.C->get_alias_index(gvn.type(adr)->isa_ptr()));
Node* mem = mm->memory_at(gvn.C->get_alias_index(access.addr().type()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of all uses of access.addr().type()?

load = LoadNode::make(gvn, control, mem, adr, val_type, access.type(), mo, dep,
requires_atomic_access, unaligned, mismatched, unsafe, access.barrier_data());
load = gvn.transform(load);
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ void CardTableBarrierSetC2::post_barrier(GraphKit* kit,

// Combine card table base and card offset
Node* card_adr = __ AddP(__ top(), byte_map_base_node(kit), card_offset);
int adr_type = Compile::AliasIdxRaw;

// Dirty card value to store
Node* dirty = __ ConI(CardTable::dirty_card_val());

Expand Down