8353053: (fs) Add support for UserDefinedFileAttributeView on AIX

[varada1110]

In AIX, the JFS2 supports extended attributes which has fgetea, fsetea, flistea, femoveea APIs support fetching, setting, listing and removing extended attributes.

JBS: JDK-8353053

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353053: (fs) Add support for UserDefinedFileAttributeView on AIX (Enhancement - P4)

Reviewers

• Joachim Kern (@JoKern65 - Committer) Review applies to 6866e532
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24276/head:pull/24276
$ git checkout pull/24276

Update a local copy of the PR:
$ git checkout pull/24276
$ git pull https://git.openjdk.org/jdk.git pull/24276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24276

View PR using the GUI difftool:
$ git pr show -t 24276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24276.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@varada1110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353053: (fs) Add support for UserDefinedFileAttributeView on AIX

Reviewed-by: mdoerr, jkern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

• a13e34d: 8353274: [PPC64] Bug related to -XX:+UseCompactObjectHeaders -XX:-UseSIGTRAP in JDK-8305895
• 41d4a0d: 8352392: AIX: implement attach API v2 and streaming output
• 1c2a553: 8327858: Improve spliterator and forEach for single-element immutable collections
• a449aee: 8350704: Create tests to ensure the failure behavior of core reflection APIs
• 57df89c: 8353684: [BACKOUT] j.u.l.Handler classes create deadlock risk via synchronized publish() method
• ebcb9a8: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method
• d894b78: 8353588: [REDO] DaCapo xalan performance with -XX:+UseObjectMonitorTable
• db08726: 8352966: Opensource Several Font related tests - Batch 2
• 6b7b324: 8351431: Type annotations on new class creation expressions can't be retrieved
• 64b691a: 8271870: G1: Add objArray splitting when scanning object with evacuation failure
• ... and 107 more: https://git.openjdk.org/jdk/compare/41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@varada1110 The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (dc2be404)
• 03: Full - Incremental (d6ef10ea)
• 02: Full - Incremental (5defce85)
• 01: Full - Incremental (6866e532)
• 00: Full (38b140f8)

[varada1110]

@sxa could you please review it? Is there any additional changes required

[sxa]

@sxa could you please review it? Is there any additional changes required

I don't believe I can give a formal review, but I've tested your fix and it seems to resolve the issues I was seeing :-)

[JoKern65]

I tried to test your changes by running

jdk/java/nio/file/attribute/
UserDefinedFileAttributeView/Basic.java

but I still get UserDefinedFileAttributeView not supported - skip test

[varada1110]

The initial behavior:
The test test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java passes with the output UserDefinedFileAttributeView not supported - skip test. This happens because AIX does not have the necessary code changes to support UserDefinedFileAttributeView, and by default, extended attributes (EA) are disabled, returning false for AIX.

With the addition of UserDefinedFileAttributeView support:

If EA is enabled on the system, the test runs successfully without being skipped.
If EA is disabled, the test behaves as before, skipping with the same output.
To ensure the test runs correctly, EA needs to be set to version 2 on AIX for the /tmp directory where the test file is created.

Could you check whether EA is enabled on your system?

[sxa]

I tried to test your changes by running

jdk/java/nio/file/attribute/
UserDefinedFileAttributeView/Basic.java

but I still get UserDefinedFileAttributeView not supported - skip test

Running chfs ea=v2 on the appropriate file system (probably /tmp) is needed as well as this fix. lsfs -q will show the current status - if it shows EAformat: v2 then it's in a compatible state.

[JoKern65]

I tried to test your changes by running

jdk/java/nio/file/attribute/
UserDefinedFileAttributeView/Basic.java

but I still get UserDefinedFileAttributeView not supported - skip test

Running chfs ea=v2 on the appropriate file system (probably /tmp) is needed as well as this fix. lsfs -q will show the current status - if it shows EAformat: v2 then it's in a compatible state.

I already did it with our administrator this morning and it looks much better now. I will further investigate and approve if I do not find anything else.

[JoKern65]

I tested the UserDefinedAttributesView on AIX. For me symlinks seem to be not supported, bat that is OK as mentioned.

[AlanBateman]

The changes to the non-AIX specific files look okay, I assume the copyright headers will be updated before the changes are integrated

[varada1110]

Thanks for the reviews. I have updated the copyright headers

[TheRealMDoerr]

Thanks for cleaning this up!

[varada1110]

Thanks all!
/integrate

[openjdk]

Going to push as commit 1161b56.
Since your change was applied there have been 117 commits pushed to the master branch:

• a13e34d: 8353274: [PPC64] Bug related to -XX:+UseCompactObjectHeaders -XX:-UseSIGTRAP in JDK-8305895
• 41d4a0d: 8352392: AIX: implement attach API v2 and streaming output
• 1c2a553: 8327858: Improve spliterator and forEach for single-element immutable collections
• a449aee: 8350704: Create tests to ensure the failure behavior of core reflection APIs
• 57df89c: 8353684: [BACKOUT] j.u.l.Handler classes create deadlock risk via synchronized publish() method
• ebcb9a8: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method
• d894b78: 8353588: [REDO] DaCapo xalan performance with -XX:+UseObjectMonitorTable
• db08726: 8352966: Opensource Several Font related tests - Batch 2
• 6b7b324: 8351431: Type annotations on new class creation expressions can't be retrieved
• 64b691a: 8271870: G1: Add objArray splitting when scanning object with evacuation failure
• ... and 107 more: https://git.openjdk.org/jdk/compare/41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26...master

Your commit was automatically rebased without conflicts.

[openjdk]

@varada1110 Pushed as commit 1161b56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.