8353002: Remove unnecessary Windows version check in WTaskbarPeer by gredler · Pull Request #24287 · openjdk/jdk

gredler · 2025-03-28T09:41:22Z

WTaskbarPeer contains a check as to whether the current Windows version is Windows 7 or later. The current minimum supported version is Windows 10, so this is no longer needed.

There didn't seem to be a public test exercising this code, so I also added a basic Taskbar sanity test.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8353002: Remove unnecessary Windows version check in WTaskbarPeer (Bug - P5)

Reviewers

Phil Race (@prrace - Reviewer)
Sergey Bylokhov (@mrserb - Reviewer)
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24287/head:pull/24287
$ git checkout pull/24287

Update a local copy of the PR:
$ git checkout pull/24287
$ git pull https://git.openjdk.org/jdk.git pull/24287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24287

View PR using the GUI difftool:
$ git pr show -t 24287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24287.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-03-28T09:42:04Z

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-03-28T09:42:49Z

@gredler This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353002: Remove unnecessary Windows version check in WTaskbarPeer

Reviewed-by: prr, serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 694 new commits pushed to the master branch:

5481021: 8321591: (fs) Improve String -> Path conversion performance (win)
885cf0f: 8353671: Remove dead code missed in JDK-8350459
1b6f694: 8353304: Open source two JTabbedPane tests
... and 691 more: https://git.openjdk.org/jdk/compare/55097dd4cbb5d691c12cb0247d66dce593759d59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-03-28T09:43:52Z

@gredler The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-03-28T09:47:20Z

Webrevs

00: Full (ab72f571)

aivanov-jdk · 2025-03-28T19:28:58Z

src/java.desktop/windows/classes/sun/awt/windows/WTaskbarPeer.java

-            supported = OSInfo.getWindowsVersion()
-                    .compareTo(OSInfo.WINDOWS_7) >= 0
-                    && ShellFolder.invoke(() -> nativeInit());
+            supported = ShellFolder.invoke(() -> nativeInit());


I wonder what will happen if I start java.exe on a system with Windows Vista which doesn't support these features.

If the native code returns an error, then it's fine.

I ask this question not only out of curiosity but also because it looks like people run Java apps on Windows versions before Windows 10. We had to implement fallback for older versions of Windows in JDK-8321151.

Interesting, thanks for the link!

One issue I see with JDK-8294427 is that it didn't work all the way back to the original Windows 10 release, which conflicts with the Oracle compatibility matrix.

But besides that, I'm surprised that a fix was implemented and tested targeting Windows 7 compatibility. Is there a different OpenJDK compatibility matrix that I should be aware of? If not, what were the criteria dictating that Windows 7 compatibility be maintained (at least in 2023)?

The biggest issue with JDK-8294427 is that it was backported to older updates, including JDK 11, which is still in use on legacy systems. I think it's reasonable to assume that JDK 25 is supported on Windows 7 and later. However, it would be good to add a notice in JBS stating that it should not be backported.

Ah, that makes sense -- so the gray area here are releases which technically do not currently support these older Windows versions, but did originally when they were first released, and we don't want to break that compatibility.

I've added a backporting note in JBS, as suggested. Is there a label I should add in JBS as well?

@aivanov-jdk Does that make sense / work for you as well?

@mrserb I'm assuming you meant "I think it's reasonable to assume that JDK 25 is supported on Windows 7 10 and later", is that right?

FYI Microsoft still support some updates of Windows 7 .. if you pay them enough, but they do NOT support
the earliest updates of Windows 10.
So Windows 7 is more relevant today than early Windows 10 versions.
Looking at adoption numbers might tell you a similar story.
JDK 25 will ship before Windows 10 leaves mainline support - and it'll also have a long tail on the latest versions.
But Windows Vista isn't something I care about for JDK 25, although "not crashing" would be nice :-)

And yes, the backporting was the big issue with that other fix. Plus that the impact was huge.

@aivanov-jdk Are there any additional concerns from your side after the clarifications from Sergey and Phil?

Interesting, thanks for the link!

One issue I see with JDK-8294427 is that it didn't work all the way back to the original Windows 10 release, which conflicts with the Oracle compatibility matrix.

The original release of Windows 10 isn't supported by Microsoft, therefore it's not supported by Oracle.

But besides that, I'm surprised that a fix was implemented and tested targeting Windows 7 compatibility. Is there a different OpenJDK compatibility matrix that I should be aware of? If not, what were the criteria dictating that Windows 7 compatibility be maintained (at least in 2023)?

Each JDK vendor could have their own compatibility matrix which are different from Oracle.

But Windows Vista isn't something I care about for JDK 25, although "not crashing" would be nice :-)

Very true, Windows Vista is unlikely to be still in use, its adoption was low even when it was new.

gredler · 2025-04-07T19:46:58Z

/integrate

openjdk · 2025-04-07T19:47:38Z

@gredler
Your change (at version ab72f57) is now ready to be sponsored by a Committer.

aivanov-jdk · 2025-04-07T19:52:26Z

/sponsor

openjdk · 2025-04-07T19:53:40Z

Going to push as commit 3757f66.
Since your change was applied there have been 695 commits pushed to the master branch:

05ff557: 8353138: Screen capture for test TaskbarPositionTest.java, failure case
5481021: 8321591: (fs) Improve String -> Path conversion performance (win)
885cf0f: 8353671: Remove dead code missed in JDK-8350459
... and 692 more: https://git.openjdk.org/jdk/compare/55097dd4cbb5d691c12cb0247d66dce593759d59...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-07T19:53:56Z

@aivanov-jdk @gredler Pushed as commit 3757f66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Remove unnecessary Windows version check in WTaskbarPeer

ab72f57

openjdk bot added the rfr Pull request is ready for review label Mar 28, 2025

openjdk bot added the client client-libs-dev@openjdk.org label Mar 28, 2025

aivanov-jdk reviewed Mar 28, 2025

View reviewed changes

prrace approved these changes Apr 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 3, 2025

mrserb approved these changes Apr 5, 2025

View reviewed changes

aivanov-jdk approved these changes Apr 7, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 7, 2025

openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025

openjdk bot closed this Apr 7, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 7, 2025

Conversation

gredler commented Mar 28, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 28, 2025

Uh oh!

openjdk bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 28, 2025

Uh oh!

mlbridge bot commented Mar 28, 2025

Webrevs

Uh oh!

aivanov-jdk Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

gredler Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

mrserb Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

gredler Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

prrace Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

gredler Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

gredler commented Apr 7, 2025

Uh oh!

openjdk bot commented Apr 7, 2025

Uh oh!

aivanov-jdk commented Apr 7, 2025

Uh oh!

openjdk bot commented Apr 7, 2025

Uh oh!

openjdk bot commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

gredler commented Mar 28, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Mar 28, 2025 •

edited

Loading