Skip to content

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Mar 28, 2025

Few events tests are opensourced

  • java/awt/event/ClickEventsTest.java
  • java/awt/event/WindowActivatedEventTest.java

Testing is good


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352860: Open source events tests batch0 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24293/head:pull/24293
$ git checkout pull/24293

Update a local copy of the PR:
$ git checkout pull/24293
$ git pull https://git.openjdk.org/jdk.git pull/24293/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24293

View PR using the GUI difftool:
$ git pr show -t 24293

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24293.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352860: Open source events tests batch0

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2025
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

Going to push as commit d4d1835.
Since your change was applied there have been 113 commits pushed to the master branch:

  • c9c3c15: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
  • 804a8fa: 8352765: G1CollectedHeap::expand_and_allocate() may fail to allocate even after heap expansion succeeds
  • 22f630c: 8352415: x86: Tighten up template interpreter method entry code
  • 6fbaa06: 8353176: C1: x86 patching stub always calls Thread::current()
  • 79d0c94: 8352114: New test runtime/interpreter/CountBytecodesTest.java is failing
  • 23e3b3f: 8351156: C1: Remove FPU stack support after 32-bit x86 removal
  • 2592513: 8350577: Fix missing Assertion Predicates when splitting loops
  • 59629f8: 8351040: [REDO] Protection zone for easier detection of accidental zero-nKlass use
  • 8cbadf7: 8317976: Optimize SIMD sort for AMD Zen 4
  • b9d7a75: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class
  • ... and 103 more: https://git.openjdk.org/jdk/compare/02a4ce23f8353a9dd6400f2dd44f9cc1649626d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 31, 2025
@openjdk openjdk bot closed this Mar 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@azvegint Pushed as commit d4d1835.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants