Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253348: Remove unimplemented JNIHandles::initialize #243

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 18, 2020

Seems to be a left-over from JDK-8227053 that removed the definition, but left the declaration behind.

Testing:

  • Linux x86_64 fastdebug build
  • Text search for JNIHandles::initialize in src/hotspot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253348: Remove unimplemented JNIHandles::initialize

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/243/head:pull/243
$ git checkout pull/243

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@shipilev The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253348: Remove unimplemented JNIHandles::initialize

Reviewed-by: zgu
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 18 commits pushed to the master branch:

  • bca9e55: 8253167: ARM32 builds fail after JDK-8247910
  • cc7521c: 8252199: Reimplement support of Type 1 fonts without MappedByteBuffer
  • 3d88d38: 8252070: Some platform-specific BLIT optimizations are not effective
  • 83b0537: 8253291: bug7072653.java still failed "Popup window height ... is wrong"
  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/11c4ea963c3d6dbfcecf725409ce285ac7a8ac1a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate bca9e55b1e522cc21b6a53a87fadac4a09688799.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
@shipilev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2020
@openjdk
Copy link

openjdk bot commented Sep 21, 2020

@shipilev Since your change was applied there have been 18 commits pushed to the master branch:

  • bca9e55: 8253167: ARM32 builds fail after JDK-8247910
  • cc7521c: 8252199: Reimplement support of Type 1 fonts without MappedByteBuffer
  • 3d88d38: 8252070: Some platform-specific BLIT optimizations are not effective
  • 83b0537: 8253291: bug7072653.java still failed "Popup window height ... is wrong"
  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub
  • 22f7af7: 8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option
  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/11c4ea963c3d6dbfcecf725409ce285ac7a8ac1a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 388c8f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8253348-jnihandles-init branch September 21, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants