8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead

[chhagedorn]

As already suggested in #23823, I want to do the following additional verification:

After eliminate_useless_predicates() all now useless OpaqueTemplateAssertionPredicate nodes should not have any references to CountedLoop nodes that are still in the graph (otherwise, they would have been marked useful). This verification did not work reliably without the full Assertion Predicates fix JDK-8350577. Since JDK-8350577 is now integrated, I propose to add this additional verification code.

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead (Sub-task - P4)

Reviewers

• Roland Westrelin (@rwestrel - Reviewer) Review applies to 38e8e865
• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24326/head:pull/24326
$ git checkout pull/24326

Update a local copy of the PR:
$ git checkout pull/24326
$ git pull https://git.openjdk.org/jdk.git pull/24326/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24326

View PR using the GUI difftool:
$ git pr show -t 24326

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24326.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead

Reviewed-by: epeter, roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• 8fb67ac: 8282053: IGV: refine schedule approximation
• d358f5f: 8347449: C2: UseLoopPredicate off should also turn UseProfiledLoopPredicate off
• f301663: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1
• 15d36ee: 8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier
• e6fe249: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"
• 096e70d: 8352437: Support --add-exports with -XX:+AOTClassLinking
• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
• 6891490: 8353324: Clean up of comments and import after 8319192
• 07fd666: 8342984: Bump minimum boot jdk to JDK 24
• ... and 38 more: https://git.openjdk.org/jdk/compare/25925138b0a7d781d9293e52a8c9520329a85219...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (14a90a8b)
• 00: Full (38e8e865)

[rwestrel]

Looks good to me.

[chhagedorn]

Thanks Roland for your review!

[eme64]

Looks reasonable, nice to see more verification code :)

[chhagedorn]

Thanks Emanuel for your review!

[chhagedorn]

Testing looked good!

/integrate

[openjdk]

Going to push as commit c9baa8a.
Since your change was applied there have been 51 commits pushed to the master branch:

• b80b04d: 8353329: Small memory leak when create GrowableArray with initial size 0
• 4a50778: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS
• 9076673: 8304674: File java.c compile error with -fsanitize=address -O0
• 8fb67ac: 8282053: IGV: refine schedule approximation
• d358f5f: 8347449: C2: UseLoopPredicate off should also turn UseProfiledLoopPredicate off
• f301663: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1
• 15d36ee: 8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier
• e6fe249: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"
• 096e70d: 8352437: Support --add-exports with -XX:+AOTClassLinking
• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• ... and 41 more: https://git.openjdk.org/jdk/compare/25925138b0a7d781d9293e52a8c9520329a85219...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit c9baa8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.