8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683#24327
8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683#24327magicus wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
|
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/author set @cnqpzhang |
|
@magicus |
|
/integrate |
|
Going to push as commit cef5610.
Your commit was automatically rebased without conflicts. |
It turns out one instance of STATIC_LIB_CFLAGS was missed in Flags.gmk when fixing JDK-8345683. This was noticed by @cnqpzhang in https://github.com/openjdk/jdk/pull/24115/files#r2011164138.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24327/head:pull/24327$ git checkout pull/24327Update a local copy of the PR:
$ git checkout pull/24327$ git pull https://git.openjdk.org/jdk.git pull/24327/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24327View PR using the GUI difftool:
$ git pr show -t 24327Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24327.diff
Using Webrev
Link to Webrev Comment