Skip to content

8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683#24327

Closed
magicus wants to merge 1 commit intoopenjdk:masterfrom
magicus:fix-static-lib-cflags
Closed

8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683#24327
magicus wants to merge 1 commit intoopenjdk:masterfrom
magicus:fix-static-lib-cflags

Conversation

@magicus
Copy link
Member

@magicus magicus commented Mar 31, 2025

It turns out one instance of STATIC_LIB_CFLAGS was missed in Flags.gmk when fixing JDK-8345683. This was noticed by @cnqpzhang in https://github.com/openjdk/jdk/pull/24115/files#r2011164138.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24327/head:pull/24327
$ git checkout pull/24327

Update a local copy of the PR:
$ git checkout pull/24327
$ git pull https://git.openjdk.org/jdk.git pull/24327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24327

View PR using the GUI difftool:
$ git pr show -t 24327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24327.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@magicus
Copy link
Member Author

magicus commented Mar 31, 2025

/author set @cnqpzhang

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@magicus
Setting overriding author to Patrick Zhang <qpzhang@openjdk.org>. When this pull request is integrated, the overriding author will be used in the commit.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 31, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 31, 2025
@magicus
Copy link
Member Author

magicus commented Apr 1, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

Going to push as commit cef5610.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 6801eb8: 8352709: Remove bad timing annotations from WhileOpTest.java
  • 85a0baf: 8352719: Add an equals sign to the modules statement
  • f25f701: 8353226: JFR: emit old object samples must be transitive closure complete for segment
  • aff5aa7: 8350566: NMT: add size parameter to MemTracker::record_virtual_memory_tag
  • 196334f: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java for AIX and Linux/musl is brittle
  • ad48846: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
  • 8b4e190: 8353349: ProblemList runtime/cds/appcds/SignedJar.java
  • 860a789: 8353219: RISC-V: Fix client builds after JDK-8345298
  • a83760a: 8352092: -XX:AOTMode=record crashes with InstanceKlass in allocated state
  • 1077265: 8353321: [macos] ErrorTest.testAppContentWarning test case requires signing environment
  • ... and 14 more: https://git.openjdk.org/jdk/compare/d4d18350f367a18813d0d418169e852c1530418e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2025
@openjdk openjdk bot closed this Apr 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@magicus Pushed as commit cef5610.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the fix-static-lib-cflags branch April 1, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants