Skip to content

8352675: Support Intel AVX10 converged vector ISA feature detection #24329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
+493 −249
Closed

8352675: Support Intel AVX10 converged vector ISA feature detection #24329

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b95ac21
8352675: Support Intel AVX10 converged vector ISA feature detection
Apr 3, 2025
6a02fe9
dropping unneeded feature enabling/checks
Apr 17, 2025
5173ff4
Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8352675
Apr 22, 2025
5d09adb
Add dynamic sized feature vectors
Apr 23, 2025
862217b
Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8352675
Apr 24, 2025
f413e0e
Fix windows build
Apr 25, 2025
9d62427
Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8352675
May 1, 2025
a925817
Refactoring code to create a seperate VM_Features class
May 2, 2025
ccfa432
Review comments resolutions
May 5, 2025
7b414b8
Updating comment
May 5, 2025
b25cc77
Review comments resolutions
May 6, 2025
650e3d6
build fixes for non-x86 targets
May 6, 2025
35aeb88
cleanups & refactorings
iwanowww May 6, 2025
cfc09d0
Making _features_bitmap size configurable
May 7, 2025
8acbd7a
Reveiw suggestions incorporated
May 8, 2025
1a3bce9
Code re-factoring from Vladimir
May 8, 2025
c65f077
Addressing Yudi's comments
May 8, 2025
b4838d0
Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8352675
May 9, 2025
f583a52
Sandhya's review comments resoultion
May 9, 2025
b4654fa
Review comments resolutions
May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/cpu/x86/vmStructs_x86.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
volatile_nonstatic_field(JavaFrameAnchor, _last_Java_fp, intptr_t*) \
static_field(VM_Version, _features, VM_Version::VM_Features) \
nonstatic_field(VM_Version::VM_Features, _features_bitmap[0], uint64_t) \
static_field(VM_Version::VM_Features, _features_bitmap_size_in_bytes, int)
static_field(VM_Version::VM_Features, _features_bitmap_size, int)

#define VM_TYPES_CPU(declare_type, declare_toplevel_type, declare_oop_type, declare_integer_type, declare_unsigned_integer_type) \
declare_toplevel_type(VM_Version::VM_Features)
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/cpu/x86/vm_version_x86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ address VM_Version::_cpuinfo_cont_addr_apx = nullptr;
static BufferBlob* stub_blob;
static const int stub_size = 2000;

int VM_Version::VM_Features::_features_bitmap_size_in_bytes = sizeof(VM_Version::VM_Features::_features_bitmap);
int VM_Version::VM_Features::_features_bitmap_size = sizeof(VM_Version::VM_Features::_features_bitmap) / BytesPerLong;

VM_Version::VM_Features VM_Version::_features;
VM_Version::VM_Features VM_Version::_cpu_features;
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/cpu/x86/vm_version_x86.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ class VM_Version : public Abstract_VM_Version {
return (1ULL << (feature & features_bitmap_element_mask()));
}

static int _features_bitmap_size_in_bytes; // for JVMCI purposes
static int _features_bitmap_size; // for JVMCI purposes
public:
VM_Features() {
for (int i = 0; i < features_bitmap_element_count(); i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/jvmci/vmStructs_jvmci.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@
static_field(VM_Version, _features, VM_Version::VM_Features) \
\
nonstatic_field(VM_Version::VM_Features, _features_bitmap[0], uint64_t) \
static_field(VM_Version::VM_Features, _features_bitmap_size_in_bytes, int) \
static_field(VM_Version::VM_Features, _features_bitmap_size, int) \
static_field(VM_Version, _has_intel_jcc_erratum, bool)

#define VM_INT_CONSTANTS_CPU(declare_constant, declare_preprocessor_constant) \
Expand Down
4 changes: 3 additions & 1 deletion src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/amd64/AMD64HotSpotVMConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class AMD64HotSpotVMConfig extends HotSpotVMConfigAccess {

final long vmVersionFeatures = getFieldAddress("VM_Version::_features", "VM_Version::VM_Features");
final long vmFeaturesFeaturesOffset = getFieldOffset("VM_Version::VM_Features::_features_bitmap[0]", Long.class, "uint64_t");
final long vmFeaturesFeaturesSize = getFieldValue("VM_Version::VM_Features::_features_bitmap_size_in_bytes", Long.class, "int");
final long vmFeaturesFeaturesSize = getFieldValue("VM_Version::VM_Features::_features_bitmap_size", Long.class, "int");

// CPU capabilities
final int useSSE = getFlag("UseSSE", Integer.class);
Expand Down Expand Up @@ -90,4 +90,6 @@ class AMD64HotSpotVMConfig extends HotSpotVMConfigAccess {
final long amd64OSPKE = getConstant("VM_Version::CPU_OSPKE", Long.class);
final long amd64CET_IBT = getConstant("VM_Version::CPU_CET_IBT", Long.class);
final long amd64CET_SS = getConstant("VM_Version::CPU_CET_SS", Long.class);
final long amd64AVX10_1 = getConstant("VM_Version::CPU_AVX10_1", Long.class);
final long amd64AVX10_2 = getConstant("VM_Version::CPU_AVX10_2", Long.class);
}