8353321: [macos] ErrorTest.testAppContentWarning test case requires signing environment

[alexeysemenyukoracle]

Move ErrorTest.testAppContentWarning() test case to MacSignTest.testAppContentWarning() and rework it to fail because of faulty app content and not invalid signing identity.

MacSignTest is supposed to be a placeholder for tests that require a signing environment but don't fit in any existing signing tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353321: [macos] ErrorTest.testAppContentWarning test case requires signing environment (Enhancement - P4)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24338/head:pull/24338
$ git checkout pull/24338

Update a local copy of the PR:
$ git checkout pull/24338
$ git pull https://git.openjdk.org/jdk.git pull/24338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24338

View PR using the GUI difftool:
$ git pr show -t 24338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24338.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353321: [macos] ErrorTest.testAppContentWarning test case requires signing environment

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 52f56e6: 8353196: [macos] Contents of ".jpackage.xml" file are wrong when building .pkg from unsigned app image
• acd4da4: 8353299: VerifyJarEntryName.java test fails
• 5eee32d: 8352768: CDS test MethodHandleTest.java failed in -Xcomp mode
• 8b0602d: 8319447: Improve performance of delayed task handling
• fe8bd75: 8351290: Clarify integral only for vector operators
• 4d1de46: 8352185: Shenandoah: Invalid logic for remembered set verification
• 3e96f5c: 8351366: Remove the java.security.debug=scl option
• 4247744: 8351435: Change the default Console implementation back to the built-in one in java.base module
• 9c06dcb: 8349583: Add mechanism to disable signature schemes based on their TLS scope
• cd5a43a: 8353126: Open source events tests batch1
• ... and 4 more: https://git.openjdk.org/jdk/compare/d4d18350f367a18813d0d418169e852c1530418e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexeysemenyukoracle]

@sashamatveev PTAL

[mlbridge]

Webrevs

• 00: Full (6dd32753)

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 1077265.
Since your change was applied there have been 14 commits pushed to the master branch:

• 52f56e6: 8353196: [macos] Contents of ".jpackage.xml" file are wrong when building .pkg from unsigned app image
• acd4da4: 8353299: VerifyJarEntryName.java test fails
• 5eee32d: 8352768: CDS test MethodHandleTest.java failed in -Xcomp mode
• 8b0602d: 8319447: Improve performance of delayed task handling
• fe8bd75: 8351290: Clarify integral only for vector operators
• 4d1de46: 8352185: Shenandoah: Invalid logic for remembered set verification
• 3e96f5c: 8351366: Remove the java.security.debug=scl option
• 4247744: 8351435: Change the default Console implementation back to the built-in one in java.base module
• 9c06dcb: 8349583: Add mechanism to disable signature schemes based on their TLS scope
• cd5a43a: 8353126: Open source events tests batch1
• ... and 4 more: https://git.openjdk.org/jdk/compare/d4d18350f367a18813d0d418169e852c1530418e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 1077265.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.