8353324: Clean up of comments and import after 8319192#24339
8353324: Clean up of comments and import after 8319192#24339prrace wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
DamonGuy
left a comment
There was a problem hiding this comment.
Confirmed that the code changes do not require importing URLClassLoader. Looks straightforward and safe to me.
|
/integrate |
|
Going to push as commit 6891490.
Your commit was automatically rebased without conflicts. |
Somehow I did not commit these changes when fixing JDK-8319192
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24339/head:pull/24339$ git checkout pull/24339Update a local copy of the PR:
$ git checkout pull/24339$ git pull https://git.openjdk.org/jdk.git pull/24339/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24339View PR using the GUI difftool:
$ git pr show -t 24339Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24339.diff
Using Webrev
Link to Webrev Comment