Skip to content

8353324: Clean up of comments and import after 8319192#24339

Closed
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:synthfix
Closed

8353324: Clean up of comments and import after 8319192#24339
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:synthfix

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Mar 31, 2025

Somehow I did not commit these changes when fixing JDK-8319192


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353324: Clean up of comments and import after 8319192 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24339/head:pull/24339
$ git checkout pull/24339

Update a local copy of the PR:
$ git checkout pull/24339
$ git pull https://git.openjdk.org/jdk.git pull/24339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24339

View PR using the GUI difftool:
$ git pr show -t 24339

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24339.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353324: Clean up of comments and import after 8319192

Reviewed-by: dnguyen, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • ad48846: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
  • 8b4e190: 8353349: ProblemList runtime/cds/appcds/SignedJar.java
  • 860a789: 8353219: RISC-V: Fix client builds after JDK-8345298
  • a83760a: 8352092: -XX:AOTMode=record crashes with InstanceKlass in allocated state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8353324 8353324: Clean up of comments and import after 8319192 Mar 31, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 31, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the code changes do not require importing URLClassLoader. Looks straightforward and safe to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 1, 2025
@prrace
Copy link
Contributor Author

prrace commented Apr 1, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

Going to push as commit 6891490.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 07fd666: 8342984: Bump minimum boot jdk to JDK 24
  • 6a46d55: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
  • 19eabaf: 8353227: JFR: Prepare tests for strong parser validation
  • 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property
  • a1ab1d8: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
  • 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing
  • 1809138: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files
  • cef5610: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
  • 6801eb8: 8352709: Remove bad timing annotations from WhileOpTest.java
  • 85a0baf: 8352719: Add an equals sign to the modules statement
  • ... and 7 more: https://git.openjdk.org/jdk/compare/1077265953e6f0918f8f7625ad311f28453c893a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2025
@openjdk openjdk bot closed this Apr 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@prrace Pushed as commit 6891490.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants