Skip to content

Conversation

@kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Apr 1, 2025

Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently.
On failure, 10 attempts with sleep(200) each time, only read -1 from mbean.getProcessCpuLoad().
The method is documented to return -1 when info is not available, but want to avoid the test accepting a -1 and masking real problems.

Test failures are happening when multiple CPU load reding tests ran on the same host, at the same second.
Add a TEST.properties file containing: exclusiveAccess.dirs=.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24352/head:pull/24352
$ git checkout pull/24352

Update a local copy of the PR:
$ git checkout pull/24352
$ git pull https://git.openjdk.org/jdk.git pull/24352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24352

View PR using the GUI difftool:
$ git pr show -t 24352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24352.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

  • d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
  • 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
  • 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
  • 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
  • 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
  • 6d37e63: 8353753: Remove unnecessary forward declaration in oop.hpp
  • 9bb804b: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java
  • e17c399: 8353201: Open source Swing Tooltip tests - Set 2
  • 9fcb06f: 8352997: Open source several Swing JTabbedPane tests
  • 74c2d8f: 8353320: Open source more Swing text tests
  • ... and 100 more: https://git.openjdk.org/jdk/compare/59629f88e6fad9c1ff91be4cfea83f78f0ea503c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@kevinjwalls kevinjwalls changed the title 8353231: Test com/sun/management/OperatingSystemMXBean cpuLoad still fails intermittently 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Apr 1, 2025
@kevinjwalls kevinjwalls marked this pull request as ready for review April 1, 2025 10:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay lets give this a try.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 7, 2025
@kevinjwalls
Copy link
Contributor Author

Thanks David!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit e8c9e5c.
Since your change was applied there have been 115 commits pushed to the master branch:

  • 6ab1647: 8353637: ZGC: Discontiguous memory reservation is broken on Windows
  • c494a00: 8353559: Restructure CollectedHeap error printing
  • 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
  • 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
  • d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
  • d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
  • 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
  • 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
  • 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
  • 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
  • ... and 105 more: https://git.openjdk.org/jdk/compare/59629f88e6fad9c1ff91be4cfea83f78f0ea503c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@kevinjwalls Pushed as commit e8c9e5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants