-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently #24352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently #24352
Conversation
…fails intermittently
|
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
|
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 110 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@kevinjwalls The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay lets give this a try.
Thanks
|
Thanks David! |
|
/integrate |
|
Going to push as commit e8c9e5c.
Your commit was automatically rebased without conflicts. |
|
@kevinjwalls Pushed as commit e8c9e5c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently.
On failure, 10 attempts with sleep(200) each time, only read -1 from mbean.getProcessCpuLoad().
The method is documented to return -1 when info is not available, but want to avoid the test accepting a -1 and masking real problems.
Test failures are happening when multiple CPU load reding tests ran on the same host, at the same second.
Add a TEST.properties file containing: exclusiveAccess.dirs=.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24352/head:pull/24352$ git checkout pull/24352Update a local copy of the PR:
$ git checkout pull/24352$ git pull https://git.openjdk.org/jdk.git pull/24352/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24352View PR using the GUI difftool:
$ git pr show -t 24352Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24352.diff
Using Webrev
Link to Webrev Comment