8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

[dholmes-ora]

Revert "8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683"

This reverts commit cef5610.

This causes failures building the static libs on Windows and macOS.

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683 (Sub-task - P2)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24356/head:pull/24356
$ git checkout pull/24356

Update a local copy of the PR:
$ git checkout pull/24356
$ git pull https://git.openjdk.org/jdk.git pull/24356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24356

View PR using the GUI difftool:
$ git pr show -t 24356

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24356.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

Reviewed-by: alanb, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[magicus]

LGTM. Sorry for the mess. 😭

[mlbridge]

Webrevs

• 00: Full (f7b5c51d)

[dholmes-ora]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit a1ab1d8.
Since your change was applied there has been 1 commit pushed to the master branch:

• 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit a1ab1d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.