8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java #24359

jaikiran · 2025-04-01T16:25:58Z

Can I please get a review of this test-only change which proposes to clean up some issues noticed in the TestRedirectLinks.java test?

The javadoc/doclet/testLinkOption/TestRedirectLinks.java test has been failing intermittently in our CI. The root cause of those failures isn't yet clear and those failures are being tracked in https://bugs.openjdk.org/browse/JDK-8338439.

While investigating those failures, it was noticed that this test had some issues that could be addressed separately to rule out their role in the intermittent failures.

The commit in this PR updates the test to using existing test library classes to construct the request URL as well as for constructing the SSLContext. The test is also updated to use the correct value to represent "no response body" when calling the sendResponseHeaders() method.

The test continues to pass with this change. We will continue investigating the intermittent failure if/when it occurs again after this change.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java (Bug - P4)

Reviewers

Chen Liang (@liach - Reviewer)
Nizar Benalla (@nizarbenalla - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24359/head:pull/24359
$ git checkout pull/24359

Update a local copy of the PR:
$ git checkout pull/24359
$ git pull https://git.openjdk.org/jdk.git pull/24359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24359

View PR using the GUI difftool:
$ git pr show -t 24359

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24359.diff

Using Webrev

Link to Webrev Comment

…irectLinks.java

bridgekeeper · 2025-04-01T16:27:01Z

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-01T16:27:04Z

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java

Reviewed-by: liach, nbenalla

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

3cc43b3: 8349075: Once again allow -compilejdk in JAVA_OPTIONS
9fb3609: 8350774: Generated test- targets broken after JDK-8348998
5520ff1: 8340341: Abort in configure when using Xcode 16.0 or 16.1
3670fde: 8349467: INIT_TARGETS tab completions on "make" lost with JDK-8348998
3241b4e: 8353066: Properly detect Windows/aarch64 as build platform
37f8e41: 8347645: C2: XOR bounded value handling blocks constant folding
4dca735: 8315844: $LSB_RELEASE is not defined before use
b92a443: 8353471: ZGC: Redundant generation id in ZGeneration
cfcb330: 8353681: jpackage suppresses errors when executed with --verbose option
10d1fec: 8353679: Restructure classes in jdk.jpackage.internal package
... and 64 more: https://git.openjdk.org/jdk/compare/860a789e9153448345f19d70dd07e294a0b62223...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-01T16:27:38Z

@jaikiran The following label will be automatically applied to this pull request:

javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-01T16:30:26Z

Webrevs

01: Full - Incremental (c2452bb5)
00: Full (6a919865)

liach · 2025-04-02T00:41:31Z

test/langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java

                + x.getRequestURI());
        String newProtocol = (newServer instanceof HttpsServer) ? "https" : "http";
-        String redirectTo = newProtocol + ":/" + newServer.getAddress() + x.getRequestURI();
+        String redirectTo = null;


Suggested change

String redirectTo = null;

String redirectTo;

liach

neat cleanup

nizarbenalla

I see that the use of InetSocketAddress::toString was dropped as it's not recommended when building URL strings.

Changes look good, thanks Jaikiran.

jaikiran · 2025-04-05T01:11:49Z

Thank you Chen and Nizar for the reviews.

jaikiran · 2025-04-05T01:12:11Z

/integrate

openjdk · 2025-04-05T01:12:51Z

Going to push as commit 9bb804b.
Since your change was applied there have been 78 commits pushed to the master branch:

e17c399: 8353201: Open source Swing Tooltip tests - Set 2
9fcb06f: 8352997: Open source several Swing JTabbedPane tests
74c2d8f: 8353320: Open source more Swing text tests
31a6de2: 8353309: Open source several Swing text tests
3cc43b3: 8349075: Once again allow -compilejdk in JAVA_OPTIONS
9fb3609: 8350774: Generated test- targets broken after JDK-8348998
5520ff1: 8340341: Abort in configure when using Xcode 16.0 or 16.1
3670fde: 8349467: INIT_TARGETS tab completions on "make" lost with JDK-8348998
3241b4e: 8353066: Properly detect Windows/aarch64 as build platform
37f8e41: 8347645: C2: XOR bounded value handling blocks constant folding
... and 68 more: https://git.openjdk.org/jdk/compare/860a789e9153448345f19d70dd07e294a0b62223...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-05T01:12:58Z

@jaikiran Pushed as commit 9bb804b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRed…

6a91986

…irectLinks.java

openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025

openjdk bot added the javadoc javadoc-dev@openjdk.org label Apr 1, 2025

liach reviewed Apr 2, 2025

View reviewed changes

address review comment in test

c2452bb

liach approved these changes Apr 2, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2025

nizarbenalla approved these changes Apr 4, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Apr 5, 2025

openjdk bot closed this Apr 5, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2025

jaikiran deleted the 8338554 branch April 5, 2025 01:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java #24359

8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java #24359

Uh oh!

jaikiran commented Apr 1, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Apr 1, 2025

Uh oh!

openjdk bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Apr 1, 2025

Uh oh!

mlbridge bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

liach Apr 2, 2025

Uh oh!

liach left a comment

Uh oh!

nizarbenalla left a comment

Uh oh!

jaikiran commented Apr 5, 2025

Uh oh!

jaikiran commented Apr 5, 2025

Uh oh!

openjdk bot commented Apr 5, 2025

Uh oh!

openjdk bot commented Apr 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java #24359

8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java #24359

Uh oh!

Conversation

jaikiran commented Apr 1, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 1, 2025

Uh oh!

openjdk bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 1, 2025

Uh oh!

mlbridge bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

liach Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

liach left a comment

Choose a reason for hiding this comment

Uh oh!

nizarbenalla left a comment

Choose a reason for hiding this comment

Uh oh!

jaikiran commented Apr 5, 2025

Uh oh!

jaikiran commented Apr 5, 2025

Uh oh!

openjdk bot commented Apr 5, 2025

Uh oh!

openjdk bot commented Apr 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

jaikiran commented Apr 1, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 1, 2025 •

edited

Loading

mlbridge bot commented Apr 1, 2025 •

edited

Loading