Skip to content

8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms#24369

Closed
kuksenko wants to merge 5 commits intoopenjdk:masterfrom
kuksenko:JDK-8353478
Closed

8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms#24369
kuksenko wants to merge 5 commits intoopenjdk:masterfrom
kuksenko:JDK-8353478

Conversation

@kuksenko
Copy link
Contributor

@kuksenko kuksenko commented Apr 1, 2025

Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24369/head:pull/24369
$ git checkout pull/24369

Update a local copy of the PR:
$ git checkout pull/24369
$ git pull https://git.openjdk.org/jdk.git pull/24369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24369

View PR using the GUI difftool:
$ git pr show -t 24369

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24369.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2025

👋 Welcome back skuksenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@kuksenko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms

Reviewed-by: ecaspole

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 396 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@kuksenko The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 1, 2025
@kuksenko kuksenko changed the title Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithm 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithm Apr 1, 2025
@openjdk openjdk bot changed the title 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithm 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms Apr 1, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2025

Webrevs

Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
Copy link
Contributor

@mcpowers mcpowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good work!

As far as I can tell, the difference between old and new benchmark numbers can be attributed mostly to generated input vs static input, and Black Holes.

Consistency in benchmark naming is definitely a plus. Thanks.

kuksenko added 3 commits April 9, 2025 12:28
Specify explicit  algorithm
Specify explicit  algorithms
Specify explicit  algorithm and fix copyright typo
Copy link

@ericcaspole ericcaspole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 23, 2025
@kuksenko
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2025

Going to push as commit 3571664.
Since your change was applied there have been 398 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2025
@openjdk openjdk bot closed this Apr 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2025
@openjdk
Copy link

openjdk bot commented Apr 23, 2025

@kuksenko Pushed as commit 3571664.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants