8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms#24369
8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms#24369kuksenko wants to merge 5 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back skuksenko! A progress list of the required criteria for merging this PR into |
|
@kuksenko This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 396 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
test/micro/org/openjdk/bench/javax/crypto/small/SignatureBench.java
Outdated
Show resolved
Hide resolved
mcpowers
left a comment
There was a problem hiding this comment.
Looks good to me. Good work!
As far as I can tell, the difference between old and new benchmark numbers can be attributed mostly to generated input vs static input, and Black Holes.
Consistency in benchmark naming is definitely a plus. Thanks.
Specify explicit algorithm
Specify explicit algorithms
Specify explicit algorithm and fix copyright typo
|
/integrate |
|
Going to push as commit 3571664.
Your commit was automatically rebased without conflicts. |
Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24369/head:pull/24369$ git checkout pull/24369Update a local copy of the PR:
$ git checkout pull/24369$ git pull https://git.openjdk.org/jdk.git pull/24369/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24369View PR using the GUI difftool:
$ git pr show -t 24369Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24369.diff
Using Webrev
Link to Webrev Comment