8353471: ZGC: Redundant generation id in ZGeneration

[jsikstro]

The ZGeneration class (and in turn ZGenerationOld and ZGenerationYoung) keeps track of its own ZGenerationId, which means that the generation id does not need to be passed along as an argument when calling internal functions.

I've removed the id parameter from ZGeneration::select_relocation_set in favor of using the member variable _id.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353471: ZGC: Redundant generation id in ZGeneration (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24374/head:pull/24374
$ git checkout pull/24374

Update a local copy of the PR:
$ git checkout pull/24374
$ git pull https://git.openjdk.org/jdk.git pull/24374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24374

View PR using the GUI difftool:
$ git pr show -t 24374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24374.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353471: ZGC: Redundant generation id in ZGeneration

Reviewed-by: stefank, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 8608b16: 8348887: Create IR framework test for JDK-8347997
• 23eb648: 8353545: Improve debug info for StartOptionTest
• 4f97c4c: 8349211: Add support for intrusive trees to the utilities red-black tree
• c9baa8a: 8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead
• b80b04d: 8353329: Small memory leak when create GrowableArray with initial size 0
• 4a50778: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS
• 9076673: 8304674: File java.c compile error with -fsanitize=address -O0
• 8fb67ac: 8282053: IGV: refine schedule approximation
• d358f5f: 8347449: C2: UseLoopPredicate off should also turn UseProfiledLoopPredicate off
• f301663: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1
• ... and 5 more: https://git.openjdk.org/jdk/compare/6891490892cc0405882658e067d587ffe5401a6d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e42fcac9)

[jsikstro]

Thank you for the reviews!
/integrate

[openjdk]

Going to push as commit b92a443.
Since your change was applied there have been 50 commits pushed to the master branch:

• cfcb330: 8353681: jpackage suppresses errors when executed with --verbose option
• 10d1fec: 8353679: Restructure classes in jdk.jpackage.internal package
• 1161b56: 8353053: (fs) Add support for UserDefinedFileAttributeView on AIX
• a13e34d: 8353274: [PPC64] Bug related to -XX:+UseCompactObjectHeaders -XX:-UseSIGTRAP in JDK-8305895
• 41d4a0d: 8352392: AIX: implement attach API v2 and streaming output
• 1c2a553: 8327858: Improve spliterator and forEach for single-element immutable collections
• a449aee: 8350704: Create tests to ensure the failure behavior of core reflection APIs
• 57df89c: 8353684: [BACKOUT] j.u.l.Handler classes create deadlock risk via synchronized publish() method
• ebcb9a8: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method
• d894b78: 8353588: [REDO] DaCapo xalan performance with -XX:+UseObjectMonitorTable
• ... and 40 more: https://git.openjdk.org/jdk/compare/6891490892cc0405882658e067d587ffe5401a6d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jsikstro Pushed as commit b92a443.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.