Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed #2438

Closed
wants to merge 1 commit into from
Closed

8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed #2438

wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Feb 5, 2021

JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
The fix un-problemlists RemovingUnixDomainSocketTest and changes serviceability tests to use OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings instead of stderrShouldBeEmptyIgnoreVMWarnings


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2438/head:pull/2438
$ git checkout pull/2438

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@alexmenkov The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 5, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2021

Webrevs

@dcubed-ojdk
Copy link
Member

dcubed-ojdk commented Feb 5, 2021

What kind of testing was done in Mach5?

@plummercj
Copy link
Contributor

plummercj commented Feb 5, 2021

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@plummercj
The core-libs label was successfully removed.

Copy link
Contributor

@plummercj plummercj left a comment

Overall it looks good, but as @dcubed-ojdk hinted, sufficient mach5 testing is necessary. VM warning issues turn up during testing when extra VM options are used during various tiers and "specialized" test tasks. Simply running the tests in question through mach5 or locally isn't enough.

@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

  • 5183d8a: 8260355: AArch64: deoptimization stub should save vector registers
  • 5d8204b: 8261368: The new TestNullSetColor test is placed in the wrong group
  • f03e839: 8261127: Cleanup THREAD/TRAPS/CHECK usage in CDS code
  • 7451962: 8129776: The optimized Stream returned from Files.lines should unmap the mapped byte buffer (if created) when closed
  • ad525bc: 8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702
  • 2fd8ed0: 8240632: Note differences between IEEE 754-2019 math lib special cases and java.lang.Math
  • ace8f94: 8195744: Avoid calling ClassLoader.checkPackageAccess if security manager is not installed
  • ab65d53: 8261261: The version extra fields needs to be overridable in jib-profiles.js
  • 20d7713: 8261334: NMT: tuning statistic shows incorrect hash distribution
  • 92c6e6d: 8261254: Initialize charset mapping data lazily
  • ... and 69 more: https://git.openjdk.java.net/jdk/compare/f025bc1d5d81532a3bdb87665537de4aaf15b7ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2021
@alexmenkov
Copy link
Author

alexmenkov commented Feb 6, 2021

What kind of testing was done in Mach5?

I run all affected tests with default arguments and with "-XX:NativeMemoryTracking=detail"

@alexmenkov
Copy link
Author

alexmenkov commented Feb 6, 2021

Overall it looks good, but as @dcubed-ojdk hinted, sufficient mach5 testing is necessary. VM warning issues turn up during testing when extra VM options are used during various tiers and "specialized" test tasks. Simply running the tests in question through mach5 or locally isn't enough.

Do you have some ideas what to run?

Copy link
Contributor

@sspitsyn sspitsyn left a comment

The fix looks good to me.
I don't have good ideas how to tests it better than Alex did.
I'm not sure, we need to care about hidden warnings other than the NMT-related.

Thanks,
Serguei

@alexmenkov
Copy link
Author

alexmenkov commented Feb 10, 2021

/integrate

@openjdk openjdk bot closed this Feb 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 10, 2021
@openjdk
Copy link

openjdk bot commented Feb 10, 2021

@alexmenkov Since your change was applied there have been 104 commits pushed to the master branch:

  • 40754f1: 4841153: java.awt.geom.Rectangle2D.add(double,double) documented incorrectly
  • 4caeb39: 8260380: Upgrade to LittleCMS 2.12
  • a772639: 8261298: LinuxPackage.c, getJvmLauncherLibPath RPM->DEB typo
  • 52fc01b: 8261268: LOAD_INSTANCE placeholders unneeded for parallelCapable class loaders
  • a3d6e37: 8261302: NMT: Improve malloc site table hashing
  • ad54d8d: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 752f92b: 6211242: AreaAveragingScaleFilter(int, int): IAE is not specified
  • 3af334a: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified
  • 4619f37: 8261472: BasicConstraintsExtension::toString shows "PathLen:2147483647" if there is no pathLenConstraint
  • 699a3cd: 8223188: Removed unnecessary #ifdef __cplusplus from .cpp sources
  • ... and 94 more: https://git.openjdk.java.net/jdk/compare/f025bc1d5d81532a3bdb87665537de4aaf15b7ea...master

Your commit was automatically rebased without conflicts.

Pushed as commit cc5691c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the testVmWarnings branch Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants