Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8228988: AnnotationParser throws NullPointerException on incompatible member type #2439

Closed
wants to merge 1 commit into from

Conversation

raphw
Copy link
Member

@raphw raphw commented Feb 5, 2021

When a class is compiled against a version of an annotation that is later loaded in an incompatible manner where an enum-typed member is changed into an annotation or vice versa, the reflection API currently throws a NullPointerException upon accessing the member. Instead an AnnotationTypeMismatchException should be thrown.

This change adjusts the parsing to trigger the correct exception.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8228988: AnnotationParser throws NullPointerException on incompatible member type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2439/head:pull/2439
$ git checkout pull/2439

Update a local copy of the PR:
$ git checkout pull/2439
$ git pull https://git.openjdk.java.net/jdk pull/2439/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2439

View PR using the GUI difftool:
$ git pr show -t 2439

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2439.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2021

👋 Welcome back winterhalter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@raphw The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 5, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2021

Webrevs

@jbf
Copy link
Member

jbf commented Apr 12, 2021

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 12, 2021
@openjdk
Copy link

openjdk bot commented Apr 12, 2021

@jbf has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@raphw please create a CSR request and add link to it in JDK-8228988. This pull request cannot be integrated until the CSR request is approved.

@raphw
Copy link
Member Author

raphw commented Apr 12, 2021

Sure, I created a CSR for the change. Are those picked up automatically or is there something more I should do to have it reviewed?

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@raphw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8228988: AnnotationParser throws NullPointerException on incompatible member type

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2216 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 20, 2021
@raphw
Copy link
Member Author

raphw commented Apr 20, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@raphw
Your change (at version bddaef3) is now ready to be sponsored by a Committer.

@jddarcy
Copy link
Member

jddarcy commented Apr 20, 2021

/sponsor

@openjdk openjdk bot closed this Apr 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@jddarcy @raphw Since your change was applied there have been 2216 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit f47faf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants