Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253349: Remove unimplemented SharedRuntime::native_method_throw_unsupported_operation_exception_entry #244

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 18, 2020

The definition was removed in JDK-7196277 (confidential): 149097f

Declaration was left behind.

Testing:

  • Linux x86_64 fastdebug build
  • Text search for native_method_throw_unsupported_operation_exception_entry in src/hotspot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253349: Remove unimplemented SharedRuntime::native_method_throw_unsupported_operation_exception_entry

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/244/head:pull/244
$ git checkout pull/244

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@shipilev The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

@shipilev
Copy link
Member Author

Friendly reminder (of this trivial issue). Thanks!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

@openjdk
Copy link

openjdk bot commented Sep 23, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253349: Remove unimplemented SharedRuntime::native_method_throw_unsupported_operation_exception_entry

Reviewed-by: adityam, dholmes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 55 commits pushed to the master branch:

  • bddb822: 8253240: No javadoc for DecimalFormatSymbols.hashCode()
  • c68a31d: 8253499: Problem list runtime/cds/DeterministicDump.java
  • 93a2018: 8252195: AWT Accessibility API nested classes rely on default constructors
  • 426c904: 8253392: remove PhaseCCP_DCE declaration
  • 65af837: 8253496: [BACKOUT] JDK-8253208 Move CDS related code to a separate class
  • 581f0f2: 8253493: Shenandoah: Remove ShenandoahSerialRoot definition
  • 7b86012: 8253492: Miss comma after second copyright year in FDBigInteger.java
  • 0f26ab1: 8252518: cache result of CompilerToVM.getComponentType
  • c1df13b: 8253208: Move CDS related code to a separate class
  • 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/11c4ea963c3d6dbfcecf725409ce285ac7a8ac1a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate bddb82255cff231b635537524ebef0d3281b8273.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2020
@shipilev
Copy link
Member Author

/integrate

@shipilev shipilev closed this Sep 23, 2020
@shipilev shipilev deleted the JDK-8253349-throw-uoe branch September 23, 2020 06:34
@shipilev shipilev restored the JDK-8253349-throw-uoe branch September 23, 2020 06:34
@shipilev shipilev reopened this Sep 23, 2020
@openjdk openjdk bot closed this Sep 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2020
@openjdk
Copy link

openjdk bot commented Sep 23, 2020

@shipilev Since your change was applied there have been 55 commits pushed to the master branch:

  • bddb822: 8253240: No javadoc for DecimalFormatSymbols.hashCode()
  • c68a31d: 8253499: Problem list runtime/cds/DeterministicDump.java
  • 93a2018: 8252195: AWT Accessibility API nested classes rely on default constructors
  • 426c904: 8253392: remove PhaseCCP_DCE declaration
  • 65af837: 8253496: [BACKOUT] JDK-8253208 Move CDS related code to a separate class
  • 581f0f2: 8253493: Shenandoah: Remove ShenandoahSerialRoot definition
  • 7b86012: 8253492: Miss comma after second copyright year in FDBigInteger.java
  • 0f26ab1: 8252518: cache result of CompilerToVM.getComponentType
  • c1df13b: 8253208: Move CDS related code to a separate class
  • 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/11c4ea963c3d6dbfcecf725409ce285ac7a8ac1a...master

Your commit was automatically rebased without conflicts.

Pushed as commit bd67975.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants