Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8058176: [mlvm] Tests should tolerate exceptions caused by code cache exhaustion. #2440

Closed
wants to merge 1 commit into from

Conversation

lepestock
Copy link
Contributor

@lepestock lepestock commented Feb 5, 2021

A repetition of the #1622.

  1. Normalise meth/stress/compiler/i2c_c2i/Test.java to use MultiThreadedTest framework;
  2. Adjust MultiThreadedTest in order to accomodate the i2c_c2i test (add prepareThread method and logic);
  3. Add ThrowableTolerance and DefaultThrowableTolerance as ways to control what Throwables are accepted;
  4. Adjust MultiThreadedTest to catch Throwables and check if they are accepted;
  5. Adjust individual tests to catch possible Throwables and check if they are accepted;
  6. Un-problemlist the failing tests.

Testing vmTestBase/vm/mlvm/meth/stress run on macos-linux-windows (30 runs each) in x64 configurations, rebased on top of latest code base. Code cache was limited -XX:ReservedCodeCacheSize=8M as suggested in the case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8058176

Issue

  • JDK-8058176: [mlvm] tests should tolerate exceptions caused by code cache exhaustion ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2440/head:pull/2440
$ git checkout pull/2440

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2021

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@lepestock The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 5, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@lepestock this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8058176/public
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Feb 8, 2021
@lepestock lepestock closed this Feb 8, 2021
@lepestock
Copy link
Contributor Author

Needs reworking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant