-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Mlkem aarch64 intrinsics restructured #24419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
complete restructuring of all kyber routines removed unused and replaced code
|
👋 Welcome back adinn! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@adinn This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine? Are you proposing to target JDK 25?
|
@adinn this pull request can not be integrated into git checkout mlkem-aarch64-intrinsics-restructured
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@adinn This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Reworked version of #23663 which uses vector sequences and generator methods abstracted over them.
Progress
Warnings
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24419/head:pull/24419$ git checkout pull/24419Update a local copy of the PR:
$ git checkout pull/24419$ git pull https://git.openjdk.org/jdk.git pull/24419/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24419View PR using the GUI difftool:
$ git pr show -t 24419Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24419.diff