Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261209: isStandalone property: remove dependency on pretty-print #2442

Closed
wants to merge 1 commit into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Feb 6, 2021

A quick fix to remove isStandalone's dependency on pretty-print.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261209: isStandalone property: remove dependency on pretty-print

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2442/head:pull/2442
$ git checkout pull/2442

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2021

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 6, 2021
@openjdk
Copy link

openjdk bot commented Feb 6, 2021

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Feb 6, 2021
@JoeWang-Java
Copy link
Member Author

JoeWang-Java commented Feb 6, 2021

/csr

@openjdk openjdk bot added the csr label Feb 6, 2021
@openjdk
Copy link

openjdk bot commented Feb 6, 2021

@JoeWang-Java this pull request will not be integrated until the CSR request JDK-8261210 for issue JDK-8261209 has been approved.

@mlbridge
Copy link

mlbridge bot commented Feb 6, 2021

Webrevs

naotoj
naotoj approved these changes Feb 7, 2021
@openjdk openjdk bot removed the csr label Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261209: isStandalone property: remove dependency on pretty-print

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 7451962: 8129776: The optimized Stream returned from Files.lines should unmap the mapped byte buffer (if created) when closed
  • ad525bc: 8261281: Linking jdk.jpackage fails for linux aarch32 builds after 8254702
  • 2fd8ed0: 8240632: Note differences between IEEE 754-2019 math lib special cases and java.lang.Math
  • ace8f94: 8195744: Avoid calling ClassLoader.checkPackageAccess if security manager is not installed
  • ab65d53: 8261261: The version extra fields needs to be overridable in jib-profiles.js
  • 20d7713: 8261334: NMT: tuning statistic shows incorrect hash distribution
  • 92c6e6d: 8261254: Initialize charset mapping data lazily
  • 351d788: 8259074: regex benchmarks and tests
  • d6d5d9b: 8261231: Windows IME was disabled after DnD operation
  • 29a428f: 8261229: MethodData is not correctly initialized with TieredStopAtLevel=3
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/fac3c2d25817e56e972ca8a7b816e46a169a2d32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 8, 2021
@JoeWang-Java
Copy link
Member Author

JoeWang-Java commented Feb 9, 2021

/integrate

@openjdk openjdk bot closed this Feb 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@JoeWang-Java Since your change was applied there have been 44 commits pushed to the master branch:

  • 01d9280: 8261299: Use-after-free on failure path in LinuxPackage.c, getJvmLauncherLibPath
  • a00b130: 8261356: Clean up enum G1Mark
  • becee64: 8261279: sun/util/resources/cldr/TimeZoneNamesTest.java timed out
  • f395ee0: 8261306: ServiceLoader documentation has malformed Unicode escape
  • 8f4c15f: 8198540: Dynalink leaks memory when generating type converters
  • edd5fc8: 8261096: Convert jlink tool to use Stream.toList()
  • 2f893c2: 8260337: Optimize ImageReader lookup, used by Class.getResource
  • f0bd9db: 8257569: Failure observed with JfrVirtualMemory::initialize
  • 906faca: 8260372: [PPC64] Add support for JDK-8210498 and JDK-8222841
  • b38d5be: 8261340: Fix 'deprecated' warnings in the vmTestbase/nsk tests
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/fac3c2d25817e56e972ca8a7b816e46a169a2d32...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7c565f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8261209 branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants