8353671: Remove dead code missed in JDK-8350459

[vpaprotsk]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353671: Remove dead code missed in JDK-8350459 (Sub-task - P4)

Reviewers

• Sandhya Viswanathan (@sviswa7 - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24423/head:pull/24423
$ git checkout pull/24423

Update a local copy of the PR:
$ git checkout pull/24423
$ git pull https://git.openjdk.org/jdk.git pull/24423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24423

View PR using the GUI difftool:
$ git pr show -t 24423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24423.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vpaprotsk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353671: Remove dead code missed in JDK-8350459

Reviewed-by: sviswanathan, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• 1b6f694: 8353304: Open source two JTabbedPane tests
• 0d4d155: 8349890: Option -Djava.security.debug=x509,ava breaks special chars
• e08441c: 8353475: Open source two Swing DefaultCaret tests
• 867a030: 8352971: Increase maximum number of hold counts for ReentrantReadWriteLock
• 9a391f4: 8353278: Consolidate local file URL checks in jar: and file: URL schemes
• 4021033: 8353659: SubmissionPublisherTest::testCap1Submit times out
• 60fbf73: 8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public
• 77fff61: 8341095: Possible overflow in os::Posix::print_uptime_info
• 9128ec6: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH
• 27c8d9d: 8352686: Opensource JInternalFrame tests - series3
• ... and 37 more: https://git.openjdk.org/jdk/compare/d894b781b8f245ce8a5d28401c0abb5abb420bc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7, @seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vpaprotsk The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6cc25c33)

[vpaprotsk]

@ascarpino If you wouldn't mind, should be a quick one :)

[seanjmullan]

Can you add a link to JDK-8350459 in the JBS issue?

Also, Tony is not available right now to review, so I reviewed and approved it.

[seanjmullan]

Also, the JBS issue needs an appropriate noreg label.

[vpaprotsk]

Also, the JBS issue needs an appropriate noreg label.

Added noreg-cleanup, I think thats the best match (?)

Can you add a link to JDK-8350459 in the JBS issue?

Its already a subtask of JDK-8350459, so its 'linked' in a way (though the UI really should display the parent task in the child task, just like it does in the parent task).

I went ahead and added a 'relates-to' link anyway..

Thanks @seanjmullan for the approval!

/integrate

[openjdk]

@vpaprotsk
Your change (at version 6cc25c3) is now ready to be sponsored by a Committer.

[sviswa7]

/sponsor

[openjdk]

Going to push as commit 885cf0f.
Since your change was applied there have been 47 commits pushed to the master branch:

• 1b6f694: 8353304: Open source two JTabbedPane tests
• 0d4d155: 8349890: Option -Djava.security.debug=x509,ava breaks special chars
• e08441c: 8353475: Open source two Swing DefaultCaret tests
• ... and 44 more: https://git.openjdk.org/jdk/compare/d894b781b8f245ce8a5d28401c0abb5abb420bc8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 @vpaprotsk Pushed as commit 885cf0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.