8261270: MakeMethodNotCompilableTest fails with -XX:TieredStopAtLevel={1,2,3}

[veresov]

JDK-8251462 changed semantics of CompilationPolicy::highest_compile_level() and CompilationPolicy::can_be_compiled() to take into the account compiler availability due to command line flags restrictions. For example, if C2 is not available because of the TieredStopAtLevel setting, the answer to these queries will be that the highest level is 3, and that methods can't be compiled at level 4.

MakeMethodNotCompilableTest.java assumes (even in the presence of the mentioned restrictions) that with tiered compilation it is always the case that both compilers can be used.

This change fixes the test to take this into account.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261270: MakeMethodNotCompilableTest fails with -XX:TieredStopAtLevel={1,2,3}

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2443/head:pull/2443
$ git checkout pull/2443

[bridgekeeper]

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@veresov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (57e55d3)

[vnkozlov]

Good.

[openjdk]

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261270: MakeMethodNotCompilableTest fails with -XX:TieredStopAtLevel={1,2,3}

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 74d40ab: 8261200: Some code in the ICC_Profile may not close file streams properly
• d7acfae: Merge
• 4de3a6b: 8260709: C2: assert(false) failed: unscheduable graph
• 5307afa: 8260585: AArch64: Wrong code generated for shifting right and accumulating four unsigned short integers
• fb46d4e: 8259268: Refactor InheritIO shell test as java test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[veresov]

/integrate

[openjdk]

@veresov Since your change was applied there have been 7 commits pushed to the master branch:

• 7a2db85: 8261022: Fix incorrect result of Math.abs() with char type
• 2c3a86f: 8261280: Remove THREAD argument from compute_loader_lock_object
• 74d40ab: 8261200: Some code in the ICC_Profile may not close file streams properly
• d7acfae: Merge
• 4de3a6b: 8260709: C2: assert(false) failed: unscheduable graph
• 5307afa: 8260585: AArch64: Wrong code generated for shifting right and accumulating four unsigned short integers
• fb46d4e: 8259268: Refactor InheritIO shell test as java test

Your commit was automatically rebased without conflicts.

Pushed as commit 0e18634.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.