-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8353735: [JVMCI] Allow specifying storage kind of the callee save register #24451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
|
@mur47x111 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/code/RegisterConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mur47x111 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good.
|
Tier1-3 passed. Thanks for the review! |
|
Going to push as commit 74e981e.
Your commit was automatically rebased without conflicts. |
|
@mur47x111 Pushed as commit 74e981e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Windows x64 ABI considers the upper portions of YMM0-YMM15 and ZMM0-ZMM15 volatile, that is, destroyed on function calls. This PR allows
RegisterConfigimplementations to refine the storage kind of callee save register, such that JVMCI compiler can exploit this information to avoid saving full width of these registers.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24451/head:pull/24451$ git checkout pull/24451Update a local copy of the PR:
$ git checkout pull/24451$ git pull https://git.openjdk.org/jdk.git pull/24451/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24451View PR using the GUI difftool:
$ git pr show -t 24451Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24451.diff
Using Webrev
Link to Webrev Comment